Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msal-node-extensions] Introducing KeyRingPersistence which uses @napi-rs/keyring and provides cross platform secure store operations #7497

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

altinokdarici
Copy link
Contributor

This pull request introduces several changes to the msal-node-extensions package, focusing on updating dependencies, improving platform support, and deprecating old persistence classes in favor of a new implementation. The most important changes include the introduction of KeyRingPersistence, updates to the rollup.config.js file, and modifications to the documentation to reflect these changes.

New Persistence Implementation:

  • Added KeyRingPersistence class to handle secure storage across multiple platforms using the @napi-rs/keyring library. This class replaces the need for platform-specific persistence classes.

Dependency Updates:

  • Updated package.json to replace the keytar dependency with @napi-rs/keyring and added @rollup/plugin-commonjs.

Build Configuration:

  • Updated rollup.config.js to include @rollup/plugin-commonjs and exclude native dependencies from the bundle. [1] [2] [3] [4] [5]

Deprecation of Old Classes:

  • Deprecated KeychainPersistence and LibSecretPersistence classes in favor of the new KeyRingPersistence class. [1] [2]

Documentation Updates:

  • Updated msal-node-extensions.md to reflect the new KeyRingPersistence class and removed the old platform-specific persistence examples. [1] [2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant