Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add Top story promo styling to existing story promo component #578

Merged
merged 25 commits into from
Jun 17, 2019

Conversation

dr3
Copy link
Contributor

@dr3 dr3 commented Jun 5, 2019

Resolves #572

Overall change: Adds styles for top story promo, a variation on the regular story promo

Code changes:

  • Adds custom styling based on a prop to alter the styles if a story is the 'top story'

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@dr3 dr3 added ws-home Tasks for the WS Home Team ws-fp-v1 labels Jun 5, 2019
@dr3 dr3 self-assigned this Jun 5, 2019
DenisHdz
DenisHdz previously approved these changes Jun 5, 2019
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 💅🏼

ghost
ghost previously approved these changes Jun 6, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@dr3 dr3 dismissed stale reviews from ghost and DenisHdz via 524576a June 12, 2019 10:51
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 💃🏻

@dr3 dr3 requested a review from pjlee11 June 13, 2019 17:28
Copy link
Contributor

@pjlee11 pjlee11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-nowak andrew-nowak added this to the Story Promo (WS FP) milestone Jun 14, 2019
@DenisHdz
Copy link
Contributor

This PR now has conflicts

@david-boydell
Copy link

Hi @dr3 , the font-size/line-height at 599px (and below) is 16/20. In Zeplin the sizes required are 20/24, could these be updated please?

@david-boydell
Copy link

david-boydell commented Jun 17, 2019

Apologies, I'll need to check with UX what these values should be - there seems to be two variants at different widths but it's not clear what the boundaries are - hold off for now @dr3

@david-boydell
Copy link

Hi @dr3 , I've had word back from UX. The font sizes for the Top Story component should be as follows:

599-320px width: headline 22/26 and summary 15/18.
<320px: headline 20/24 and summary 15/18.

@david-boydell david-boydell self-assigned this Jun 17, 2019
@clareevansbbc clareevansbbc removed this from the Story Promo (WS FP) milestone Jun 17, 2019
@david-boydell
Copy link

This looks good, ready for merge.

@dr3 dr3 merged commit 026d76b into latest Jun 17, 2019
@dr3 dr3 deleted the TopStoryPromo branch June 17, 2019 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
high priority ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse Story Promo component for the Top Story Promo
8 participants