-
Notifications
You must be signed in to change notification settings - Fork 54
Add Top story promo styling to existing story promo component #578
Conversation
Co-Authored-By: Denis Hernandez <[email protected]>
Co-Authored-By: Denis Hernandez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 💅🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 💃🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR now has conflicts |
Hi @dr3 , the font-size/line-height at 599px (and below) is 16/20. In Zeplin the sizes required are 20/24, could these be updated please? |
Apologies, I'll need to check with UX what these values should be - there seems to be two variants at different widths but it's not clear what the boundaries are - hold off for now @dr3 |
Hi @dr3 , I've had word back from UX. The font sizes for the Top Story component should be as follows: 599-320px width: |
This looks good, ready for merge. |
Resolves #572
Overall change: Adds styles for top story promo, a variation on the regular story promo
Code changes: