Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samtools in some mulled containers #2854

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

nvnieuwk
Copy link
Contributor

No description provided.

@nvnieuwk nvnieuwk mentioned this pull request Nov 29, 2023
14 tasks
@FriederikeHanssen
Copy link
Contributor

What about bwa and bwamem2?

@bgruening
Copy link
Member

Is there any new feature in samtools that you need? Please keep in mind that someone needs to pay the bill for those containers

@nvnieuwk
Copy link
Contributor Author

Not really, just a version bump. I understand if you don't want to submit these because of this

@FriederikeHanssen
Copy link
Contributor

For the mapping mulled containers: there seem to be several bug fixes for dealing with CRAM files and sorting: https://github.com/samtools/samtools/releases/

@bgruening
Copy link
Member

Are you hitting those bugs? :)
I just want to raise the issue of environmental impact and cost. So there is a tradeoff. Updating all containers with samtools, with every samtools version is not scalable imho.

An alternative would be that you run samtools as a separate container - which we already provide.

@nvnieuwk
Copy link
Contributor Author

I'm personally not hitting them, @FriederikeHanssen do you know of anyone having issues?

@bgruening
Copy link
Member

That said, if you think the fixes are worthwhile and you need the memory fixes, lets do it. Please just don't do this for the sake of it.

@nvnieuwk If you add too many updates into one container, the CI will time out or we run out of space, you need to create multiple PRs.

@nvnieuwk
Copy link
Contributor Author

Okay, I'll just remove some of the lesser used containers. We can still add them later if needed. Thanks!

@nvnieuwk
Copy link
Contributor Author

@bgruening all PRs are done and CI is passing

@bgruening bgruening enabled auto-merge November 30, 2023 10:25
auto-merge was automatically disabled November 30, 2023 12:14

Head branch was pushed to by a user without write access

@nvnieuwk
Copy link
Contributor Author

@bgruening I fixed the CI failures :)

@bgruening bgruening merged commit f2eba73 into BioContainers:master Nov 30, 2023
1 check passed
@bgruening
Copy link
Member

Thanks

@nvnieuwk
Copy link
Contributor Author

Thank you for the merges! The nf-core community will be very happy 🥳

@nvnieuwk nvnieuwk deleted the patch-1 branch November 30, 2023 13:33
@bgruening
Copy link
Member

Your welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants