-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samtools in some mulled containers #2854
Conversation
What about bwa and bwamem2? |
Is there any new feature in samtools that you need? Please keep in mind that someone needs to pay the bill for those containers |
Not really, just a version bump. I understand if you don't want to submit these because of this |
For the mapping mulled containers: there seem to be several bug fixes for dealing with CRAM files and sorting: https://github.com/samtools/samtools/releases/ |
Are you hitting those bugs? :) An alternative would be that you run samtools as a separate container - which we already provide. |
I'm personally not hitting them, @FriederikeHanssen do you know of anyone having issues? |
That said, if you think the fixes are worthwhile and you need the memory fixes, lets do it. Please just don't do this for the sake of it. @nvnieuwk If you add too many updates into one container, the CI will time out or we run out of space, you need to create multiple PRs. |
Okay, I'll just remove some of the lesser used containers. We can still add them later if needed. Thanks! |
@bgruening all PRs are done and CI is passing |
Head branch was pushed to by a user without write access
@bgruening I fixed the CI failures :) |
Thanks |
Thank you for the merges! The nf-core community will be very happy 🥳 |
Your welcome! |
No description provided.