Skip to content

Commit

Permalink
setup.py fix and update
Browse files Browse the repository at this point in the history
- libssl dependency for Fedora
- typo in waiting for keypress
  • Loading branch information
PeterSurda committed Mar 1, 2017
1 parent af5cb08 commit 636ae17
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
compiling = {
"Debian": "build-essential libssl-dev",
"Ubuntu": "build-essential libssl-dev",
"Fedora": "gcc-c++ redhat-rpm-config python-devel",
"Fedora": "gcc-c++ redhat-rpm-config python-devel openssl-devel",
"openSUSE": "gcc-c++ libopenssl-devel python-devel",
}

Expand Down Expand Up @@ -162,7 +162,7 @@ def compilerToPackages():
if detectPrereqs(True) != []:
print "Press Return to continue"
try:
nothing = raw_input
nothing = raw_input()

This comment has been minimized.

Copy link
@g1itch

g1itch Mar 1, 2017

Collaborator

Oh no! Portage (gentoo's package manager) often uses something like /usr/bin/python2.7 setup.py build to build python packages. And it cannot press Return. I suspect some of the binary distributions listed above may do something similar when building packages.

This comment has been minimized.

Copy link
@PeterSurda

PeterSurda Mar 1, 2017

Author Member

This will only show up if there are dependencies missing, but I think that you're right, this may cause problems. If I can find out how to detect whether STDIN is a TTY in python, that would be helpful.

This comment has been minimized.

Copy link
@g1itch

g1itch Mar 1, 2017

Collaborator

It may be optional dependency like pyopencl in my case.

except NameError:
pass

Expand Down

0 comments on commit 636ae17

Please sign in to comment.