-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark ABI kernel #2094
Merged
Merged
Benchmark ABI kernel #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksdavis
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's remarkably few changes. Yay!
Should the last comment be squashed into the other RETURN commit?
The kernel config should be the last commit, not the first before anything works? |
qwattash
force-pushed
the
benchmark-abi-kernel
branch
from
May 3, 2024 15:38
8efc698
to
ce1989c
Compare
brooksdavis
reviewed
May 3, 2024
jrtc27
reviewed
May 3, 2024
qwattash
force-pushed
the
benchmark-abi-kernel
branch
from
May 3, 2024 17:43
ce1989c
to
65817fb
Compare
This is necessary to support the benchmark ABI kernel.
qwattash
force-pushed
the
benchmark-abi-kernel
branch
from
May 7, 2024 17:52
65817fb
to
eea5865
Compare
jrtc27
reviewed
May 7, 2024
jrtc27
reviewed
May 7, 2024
Using a capablity branch is not necessary here, because we jump within the current function.
Directly set tf_elr for pcb_onfault and generic_bs_fault.
Add kern.features.cheriabi_kernel for pure-capability kernels. Add kern.features.subobject_bounds for pure-capability kernels with sub-object bounds.
Add kern.features.benchmark_abi_kernel to identify Morello benchmark ABI kernels.
Add the GENERIC-MORELLO-PURECAP-BENCHMARK{-NODEBUG} configs.
qwattash
force-pushed
the
benchmark-abi-kernel
branch
from
May 8, 2024 10:13
eea5865
to
78edb47
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on QEMU, boot and cheribsdtests are passing.
Tested on Morello board, cheribsdtests are passing.
Once merged, should close #1983 .