Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark ABI kernel #2094

Merged
merged 8 commits into from
May 8, 2024
Merged

Benchmark ABI kernel #2094

merged 8 commits into from
May 8, 2024

Conversation

qwattash
Copy link
Contributor

@qwattash qwattash commented May 3, 2024

Tested on QEMU, boot and cheribsdtests are passing.
Tested on Morello board, cheribsdtests are passing.

Once merged, should close #1983 .

@qwattash qwattash requested review from jrtc27 and brooksdavis May 3, 2024 14:47
Copy link
Member

@brooksdavis brooksdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's remarkably few changes. Yay!

Should the last comment be squashed into the other RETURN commit?

sys/arm64/conf/GENERIC-MORELLO-BENCHMARKABI Outdated Show resolved Hide resolved
sys/arm64/conf/GENERIC-MORELLO-BENCHMARKABI Outdated Show resolved Hide resolved
@jrtc27
Copy link
Member

jrtc27 commented May 3, 2024

The kernel config should be the last commit, not the first before anything works?

@qwattash qwattash force-pushed the benchmark-abi-kernel branch from 8efc698 to ce1989c Compare May 3, 2024 15:38
sys/arm64/arm64/efirt_support.S Outdated Show resolved Hide resolved
sys/arm64/conf/GENERIC-MORELLO-BENCHMARKABI Outdated Show resolved Hide resolved
sys/arm64/conf/GENERIC-MORELLO-BENCHMARKABI Outdated Show resolved Hide resolved
sys/arm64/include/cheric.h Outdated Show resolved Hide resolved
sys/kern/init_main.c Outdated Show resolved Hide resolved
@qwattash qwattash force-pushed the benchmark-abi-kernel branch from ce1989c to 65817fb Compare May 3, 2024 17:43
@qwattash qwattash force-pushed the benchmark-abi-kernel branch from 65817fb to eea5865 Compare May 7, 2024 17:52
qwattash added 6 commits May 8, 2024 10:32
Using a capablity branch is not necessary here, because we jump within the current function.
Directly set tf_elr for pcb_onfault and generic_bs_fault.
Add kern.features.cheriabi_kernel for pure-capability kernels.
Add kern.features.subobject_bounds for pure-capability kernels with
sub-object bounds.
Add kern.features.benchmark_abi_kernel to identify Morello
benchmark ABI kernels.
Add the GENERIC-MORELLO-PURECAP-BENCHMARK{-NODEBUG} configs.
@qwattash qwattash force-pushed the benchmark-abi-kernel branch from eea5865 to 78edb47 Compare May 8, 2024 10:13
@qwattash qwattash merged commit a884ccc into dev May 8, 2024
28 checks passed
@qwattash qwattash deleted the benchmark-abi-kernel branch May 8, 2024 15:56
@jrtc27 jrtc27 mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants