nvi fixes #2254
Merged
nvi fixes #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace a rather convoluted realignment algorithm with memmove(). In addition to being hard to understand, the code would read beyond the end of the input buffer in certain conditions (found on CheriBSD). Sponsored by: DARPA Pull Request: lichray/nvi2#122 (cherry picked from commit 56ef9c872bc5b086d73fed6317159e40be32d40e)
We should use alignof in the future. Obtained from: lichray/nvi2@25c4d7d (cherry picked from commit 06a98fefd3d3ff42b7e7832af6c0736b98f167ac)
The weird pointer manipulation we'd been patching was infact buggy and produced out of bounds accesses. We've merged a patch upstream to use memmove instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge some fixes from upstream nvi via FreeBSD. This was the only bit of code in nvi that was changed to support CHERI and a the commit messages don't really do justice to how utterly bonkers the code was.
Fixes #2253