Fix possible out of bound read in armv8_crc32c #2293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The armv8_crc32c function uses
ldr
to load 4 bytes of data even if the remaining data could be less than 4 bytes. This causes capability bound error.This error can be triggered, for example, when accessing files in an ext2fs partition, which requires the calculation of crc32.
This piece of code also demonstrates the problem:
which prints
In-address space security exception (core dumped)
.PS: I also wonder if this should be fixed upstream as well.