Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11057: Support address query param in searches #1161

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Jan 17, 2025

UHF-11057

Adds support for prefilling address throught query param in some searches.

What was done

  • Added new reusable hook for getting initial params
  • Added reading and prefilling the address to these react searches:
    • School search
    • Health station search
    • Maternity ward search
    • Ploughing schedule
  • Additionally these view-based searches were extended to allow the same change (PR: ):
    • Playground search
    • Daycare search

How to install

Testing this feature requres setting up multiple instances.

Instances to set up:
https://github.com/City-of-Helsinki/drupal-helfi-sote
https://github.com/City-of-Helsinki/drupal-helfi-kasvatus-koulutus
https://github.com/City-of-Helsinki/drupal-helfi-kymp

For Kasko, you need to use the feature branch: City-of-Helsinki/drupal-helfi-kasvatus-koulutus#771

Set them up by running:

  • composer require drupal/hdbt:dev-UHF-11057
  • make fresh
  • drush sapi-c; drush sapi-rt; drush sapi-i

How to test

Test that the searches work and use the address supplied by query param:
Kasko:

SOTE:

KYMP:

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1161/html_report/

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1161/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants