Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9580: Hearing paragraph to basic page on KYMP #916

Merged
merged 5 commits into from
Mar 6, 2024
Merged

UHF-9580: Hearing paragraph to basic page on KYMP #916

merged 5 commits into from
Mar 6, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Mar 5, 2024 •
edited by khalima
Loading

UHF-9580

What was done

  • Styling the hearings paragraph so that it can be included on the basic page upper content region as well.
  • Adding possibility to add class when including the link-button template.
  • Fixing hearings translations.

How to install

  • Check testing instructions from the KYMP PR.

How to test

  • Check testing instructions fromt he KYMP PR.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Other PRs

@teroelonen
UHF-9580: Styling the hearings paragraph to work in the upper content…
1782e38 
… area, adding possibility to add class when including the link-button template, fixing hearings translations
@teroelonen teroelonen mentioned this pull request Mar 5, 2024
Merged
8 tasks
@teroelonen teroelonen marked this pull request as ready for review March 5, 2024 13:16
@teroelonen teroelonen added the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Mar 5, 2024
khalima
khalima approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/916/html_report/

@teroelonen teroelonen merged commit 4c0799d into main Mar 6, 2024
2 checks passed
@teroelonen teroelonen deleted the UHF-9580 branch March 6, 2024 08:19
This was referenced Mar 6, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
recreate-reference-images Use this label to re-create reference images used by Visual regression tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima