Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X: External event entity causes WSOD fix #895

Merged
merged 3 commits into from
Jan 28, 2025
Merged

UHF-X: External event entity causes WSOD fix #895

merged 3 commits into from
Jan 28, 2025

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Jan 28, 2025 •
edited by teroelonen
Loading

Prevent whitescreen when event does not have either start or end time.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-X_curated_events_whitescreen
  • Update HDBT
    • composer require drupal/hdbt:dev-UHF-X_curated_events_whitescreen
  • Run make drush-updb drush-cr

How to test

  • Add a curated event paragraphs to a page
  • Add the following events:
- Sound of Stoa
- Ilmaispäivä
- Kiasman ilmaispäivä
- DocPoint 2025
  • Save the page
  • Go see the page
    You should not see whitescreen

Other PRs

@teroelonen teroelonen mentioned this pull request Jan 28, 2025
Merged
4 tasks
@teroelonen teroelonen changed the title check that the date exists before trying to get timestamp UHF-X: External event entity causes WSOD fix Jan 28, 2025
@rpnykanen rpnykanen merged commit b60ca83 into main Jan 28, 2025
1 check passed
@rpnykanen rpnykanen deleted the UHF-X_curated_events_whitescreen branch January 28, 2025 14:33
This was referenced Jan 28, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpnykanen @khalima