Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(enterpriseTheme): Add Enterprise Theme #2935

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(enterpriseTheme): Add Enterprise Theme #2935

wants to merge 11 commits into from
+157 −1

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Sep 11, 2024 •
edited
Loading

Overview

Adds new enterprise theme

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [GM-theme]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

You can test locally by adding this commit back to your local branch.

PR Links and Envs

N/A

@dreamwasp dreamwasp marked this pull request as ready for review December 9, 2024 16:59
@dreamwasp dreamwasp requested a review from a team as a code owner December 9, 2024 16:59
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 9, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 5c010c9.

☁️ Nx Cloud last updated this comment at 2025-01-16 18:14:46 UTC

@dreamwasp dreamwasp changed the title test theme (feat): Enterprise Theme Dec 9, 2024
@dreamwasp dreamwasp changed the title (feat): Enterprise Theme feat(enterpriseTheme): Add Enterprise Theme Dec 9, 2024
@timjenkins
Copy link
Contributor

@dreamwasp do you think it's better to have this theme defined within gamut vs in the enterprise app itself?

@dreamwasp
Copy link
Contributor Author

@dreamwasp do you think it's better to have this theme defined within gamut vs in the enterprise app itself?

we're testing it in some experimental (non-Codcademy) projects so i think it makes sense to keep it here for now and then we can move it to the respective Storybook/app once its finalized

timjenkins
timjenkins approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@timjenkins timjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://67894c6a4244e34d00c660ac--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjenkins timjenkins timjenkins approved these changes

@jakemhiller jakemhiller jakemhiller approved these changes

@smithgajjar09 smithgajjar09 Awaiting requested review from smithgajjar09

@aresnik11 aresnik11 Awaiting requested review from aresnik11

@LinKCoding LinKCoding Awaiting requested review from LinKCoding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dreamwasp @timjenkins @codecademydev @jakemhiller @smithgajjar09