Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picmi_schema #5232

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mafshari64
Copy link
Contributor

@mafshari64 mafshari64 commented Dec 11, 2024

Add picmi_schema for picmi input files.

  • do not merge before picongpu 0.8.0 branch is created (psychocoderHPC)

@psychocoderHPC
Copy link
Member

Does PICMI somehow use this schema or is this an independent file.
How do we ensure that PICME is following the schema.

@psychocoderHPC psychocoderHPC added the PICMI pypicongpu and picmi related label Dec 12, 2024
@psychocoderHPC psychocoderHPC added this to the Future milestone Dec 12, 2024
@mafshari64
Copy link
Contributor Author

this schema in principle should check if the input file created based on the PICMI standard follows its role, eg units are correct.

@psychocoderHPC
Copy link
Member

But how is the PICMI file checked against the schema, I do not see an integration into the PICMI python code.

Copy link
Member

@BrianMarre BrianMarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general remarks:

  • the name of this schema is misleading since this schema has nothing to do with PICMI,

rather it describes the structure of the PyPIConGPU json description of an picongpu setup assumed by the meta data exporter, therefore it belongs to the meta data exporter and should use it's own project name to avoid confusion with the PyPIConGPU schemas.

  • this schema is mostly a repeat of the PyPIConGPU schemas, which already specify the structure of the PyPIConGPU json description.
  • this schema has nothing to do with PIConGPU and belongs to the meta data exporter project, since it describes assumptions/requirements of the meta data exporter not PIConGPU, PyPIConGPU or the PIConGPU PICMI implementation.

@psychocoderHPC psychocoderHPC marked this pull request as draft December 16, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PICMI pypicongpu and picmi related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants