Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LastUpdated.jsx #938

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update LastUpdated.jsx #938

wants to merge 1 commit into from

Conversation

sechra
Copy link

@sechra sechra commented Jan 15, 2025

0 to 1

Copy link

vercel bot commented Jan 15, 2025

@sechra is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

@jlwllmr
Copy link
Collaborator

jlwllmr commented Jan 16, 2025

Thank you @sechra - what's the rationale for the change?

The existing code will retrieve the first timestamp from the week's data, I believe, which is sufficient for our purposes. On the page itself, the component only displays a day (e.g. Jan 16), so — given the timestamps for each week's set of data are all within seconds of each other — fetching the first is absolutely fine.

Happy to make the change if there's a clear improvement, but at the moment I'm not clear what it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants