feat: optimise normalisation over binary values #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a normalisation `(~ X)` arises for a binary column `X` (or expression resulting in a binary value) then, in fact, no normalisation is actually required. Instead, we can just return `X` since it is already normalised. This is a useful optimisation since it will save an inverse column, along with two constraints.
Closed
Test_Type_05 was broken because it had a binary BIT with value 2 in its accepts data.
|
I believe this feature was already in |
|
Hey, It was not in go-corset, no. It is now! For if-then-else, this is already applied to the condition on the branches since they broken down into individual constraints using normalisation when appropriate, etc.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a normalisation
(~ X)arises for a binary columnX(or expression resulting in a binary value) then, in fact, no normalisation is actually required. Instead, we can just returnXsince it is already normalised. This is a useful optimisation since it will save an inverse column, along with two constraints.