Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore on Windows problem with mixed slashes. #64

Open
wants to merge 3 commits into
base: 3.0
Choose a base branch
from
Open

Gitignore on Windows problem with mixed slashes. #64

wants to merge 3 commits into from

Conversation

amsys
Copy link

@amsys amsys commented Aug 15, 2015

Not sure if this is the right way to do it, but my .gitignore with recent release and past releases always contained mixed slashes... for example:

/app/code/local/Aschroder/SMTPPro/Block\Log.php
/app/code/local/Aschroder/SMTPPro/controllers\Smtp\LogController.php

amsys added 3 commits March 28, 2015 11:13
@AydinHassan
Copy link
Contributor

Hi @amsys have you tested on the most recent version? This may have been fixed recently. If not it's certainly fixed in my open PR for Windows test support, however that won't be merged for a while so if it's not fixed in the latest i'm +1 for this patch. It does require a unit test though please. Ideally thid should be fixed higher in the stack but I'm working on that atm.

@martinpolivka
Copy link

Hi @AydinHassan, I vote for this change as there is real problem with mixed slashes on Windows machines. Thanks.

@AydinHassan
Copy link
Contributor

@martinpolivkasummit I have no problem with this fix, but it requires a unit-test first. Currently the tests setup for this project is broken so I can't continue the Windows fixes.

@AydinHassan
Copy link
Contributor

@amsys Could you try the master branch when you get some time? this should be fixed now.

@Flyingmana
Copy link
Contributor

sadly our resources(people) were not able to fix the windows tests yet... therefore we are not able to validate if it properly works or breaks something :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants