Fix memory leaks for huge tables #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We process each row group sequentially during "COPY FROM parquet". Normally, we expect that memory consumption does not exceed too much the row group size. But we also do some allocations during the copy at current Postgres context, which can be extreme for some huge tables (e.g. with 100 columns and default row group size ~ 123000) To fix the issue, we intoduce a memory context that is used and freed per each row during the copy.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 71 71
Lines 9104 9109 +5
=======================================
+ Hits 8386 8391 +5
Misses 718 718 ☔ View full report in Codecov by Sentry. |
marcoslot
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We process each row group sequentially during "COPY FROM parquet". Normally, we expect that memory consumption does not exceed too much the row group size. But we also do some allocations during the copy at current Postgres context, which can be extreme for some huge tables (e.g. with 100 columns and default row group size ~ 123000) To fix the issue, we introduce a memory context that is used and freed per each row during the copy.
Fixes #88.