Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destreceiver api #95

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix destreceiver api #95

merged 1 commit into from
Jan 20, 2025

Conversation

aykut-bozkurt
Copy link
Collaborator

  • We need to put *mut ParquetWriterContext into PgParquetDestReciever. As it is opaque type to C users, it is safe to do and way safer than static context which causes headache when 2 concurrent dest receiver is running.
  • PgParquetDestReceiver should not own and drop tupledesc that is received via its startup callback. That is unexpected for the caller.
  • We should not filter our dropped columns of the given tupledesc at startup callback since it cause "tupledesc does not match tuple" errors.

Base automatically changed from aykut/geoparquet to main January 20, 2025 23:00
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/fix-destreceiver-api branch from 30de679 to f4264d4 Compare January 20, 2025 23:03
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/fix-destreceiver-api branch from f4264d4 to 54d4787 Compare January 20, 2025 23:05
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.64%. Comparing base (30fb0c6) to head (54d4787).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/parquet_copy_hook/copy_to_dest_receiver.rs 90.24% 4 Missing ⚠️
src/parquet_copy_hook/hook.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   92.65%   92.64%   -0.01%     
==========================================
  Files          75       75              
  Lines        9813     9795      -18     
==========================================
- Hits         9092     9075      -17     
+ Misses        721      720       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aykut-bozkurt aykut-bozkurt merged commit 47a0209 into main Jan 20, 2025
4 of 6 checks passed
@aykut-bozkurt aykut-bozkurt deleted the aykut/fix-destreceiver-api branch January 20, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants