Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if special numeric during copy to parquet #97

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

aykut-bozkurt
Copy link
Collaborator

Do not allow copying numeric nan and +-infinity.

@aykut-bozkurt aykut-bozkurt force-pushed the aykut/fix-multiple-maps-in-table branch from 0fd5c99 to e37d709 Compare January 16, 2025 06:56
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/error-if-special-numeric branch from fa13238 to 58327af Compare January 16, 2025 06:57
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/fix-multiple-maps-in-table branch from e37d709 to 1af44ab Compare January 16, 2025 07:52
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/error-if-special-numeric branch from 58327af to 4637490 Compare January 16, 2025 07:53
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/fix-multiple-maps-in-table branch 2 times, most recently from a9ffb66 to bf97833 Compare January 21, 2025 22:31
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/error-if-special-numeric branch from 4637490 to 4056ad2 Compare January 22, 2025 13:59
Base automatically changed from aykut/fix-multiple-maps-in-table to main January 24, 2025 13:56
@aykut-bozkurt aykut-bozkurt force-pushed the aykut/error-if-special-numeric branch from 4056ad2 to b6518b1 Compare January 24, 2025 14:01
@aykut-bozkurt aykut-bozkurt enabled auto-merge (squash) January 24, 2025 14:07
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (a123f52) to head (b6518b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   91.79%   91.81%   +0.02%     
==========================================
  Files          77       77              
  Lines        9981    10007      +26     
==========================================
+ Hits         9162     9188      +26     
  Misses        819      819              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aykut-bozkurt aykut-bozkurt merged commit e775b0e into main Jan 24, 2025
6 checks passed
@aykut-bozkurt aykut-bozkurt deleted the aykut/error-if-special-numeric branch January 24, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants