-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add qualification phase for agent 6 #33339
base: main
Are you sure you want to change the base?
Conversation
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
[Fast Unit Tests Report] On pipeline 53975971 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: bc60970 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_logs | % cpu utilization | +0.89 | [-2.13, +3.91] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.88 | [+0.84, +0.91] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.20 | [-0.56, +0.97] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | +0.11 | [+0.07, +0.15] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.11 | [-0.37, +0.58] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.10 | [-0.78, +0.99] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.09 | [-0.74, +0.93] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.03, +0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.29, +0.27] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.01 | [-0.66, +0.63] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.84, +0.78] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.06 | [-0.89, +0.78] | 1 | Logs |
➖ | file_tree | memory utilization | -0.09 | [-0.14, -0.04] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.10 | [-0.17, -0.04] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.46 | [-1.25, +0.32] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.58 | [-3.46, -1.70] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
tasks/release.py
Outdated
try: | ||
ctx.run(f"git tag | grep {QUALIFICATION_TAG}", hide=True) | ||
if output: | ||
print('true') | ||
return True | ||
except Failure: | ||
if output: | ||
print("false") | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add an agent_context
+ a branch argument here to switch to the target branch
.github/workflows/create_rc_pr.yml
Outdated
- name: Rebuild agent 6 RC pipeline if no changes and in qualification phase | ||
if: ${{ env.IS_AGENT6_RELEASE == 'true' && steps.check_for_changes.outputs.CHANGES == 'false' && env.IS_QUALIFICATION == 'true' }} | ||
run: | | ||
inv -e release.run-rc-pipeline 6.53.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think it's preferable to put the explicit argument
inv -e release.run-rc-pipeline 6.53.x | |
inv -e release.run-rc-pipeline -r 6.53.x |
tasks/libs/releasing/version.py
Outdated
RC_VERSION_RE = re.compile(r'^\d+[.]\d+[.]\d+-rc\.\d+$') | ||
|
||
# Regex matching final version tag format like 7.54.0 | ||
FINAL_VERSION_RE = re.compile(r'^\d+[.]\d+[.]\d+$') | ||
|
||
# Regex matching minor release rc version tag like x.y.0-rc.1 (semver PATCH == 0), but not x.y.1-rc.1 (semver PATCH > 0) | ||
MINOR_RC_VERSION_RE = re.compile(r'\d+[.]\d+[.]0-rc\.\d+') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MINOR_RC_VERSION_RE = re.compile(r'\d+[.]\d+[.]0-rc\.\d+') | |
MINOR_RC_VERSION_RE = re.compile(r'^\d+[.]\d+[.]0-rc\.\d+$') |
As you change it for the RC_VERSION_RE
we could align the regex (knowing it's only used with re.match
we can add the boundaries ^$
)
tasks/release.py
Outdated
@task | ||
def run_rc_pipeline(ctx, release_branch, gitlab_tag=None, k8s_deployments=False): | ||
with agent_context(ctx, release_branch): | ||
if not gitlab_tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This block could stand in a get_qualification_rc_tag
method, to better illustrate its role (and to ease its testing)
fb0c103
to
df7233b
Compare
What does this PR do?
add qualification phase for agent 6 by modifying the release tasks and the create rc pr workflow
CHANGES IN RELEASE TASKS
1. start qualification phase
--start-qual
argument tobuild_rc
task--start-qual
argumentinv release.build-rc 6.53.x --start-qual
2. automatically move qualification tag when RC is bumped
is_qualification()
function to check if the current state is in qualification phasegit tag --force
to move qualification tag to new RC commitinv release.build-rc 6.53.x
(automatically checks if in qualification phase without any extra arguments)3. end qualification phase
tag_version
task to tag the final versioninv release.tag-version --version 6.53.2
CHANGES IN CREATE RC PR WORKFLOW
if current state of agent 6 is in qualification phase and there are no changes (no new commits in 6.53.x branch)
Motivation
ACIX-525
Describe how you validated your changes
ran the release tasks locally
but plan to test it fully through the next couple of agent 6 RCs
Possible Drawbacks / Trade-offs
Additional Notes