-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTEL-2396] remove non-existent module references #33376
base: main
Are you sure you want to change the base?
Conversation
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision✅ Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manually added all teams affected (since it is only go.mod files, no one was notified)
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: cd756b3 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.94 | [+0.16, +1.73] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.79 | [+0.72, +0.85] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.54 | [-0.34, +1.43] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.19 | [-0.28, +0.65] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | +0.17 | [+0.12, +0.21] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.05 | [-0.75, +0.84] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.01 | [-0.77, +0.79] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.01 | [-0.92, +0.93] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.00 | [-0.90, +0.91] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.02, +0.03] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.28, +0.26] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.89, +0.84] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.03 | [-0.67, +0.60] | 1 | Logs |
➖ | file_tree | memory utilization | -0.25 | [-0.29, -0.20] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -0.44 | [-0.48, -0.40] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_logs | % cpu utilization | -4.85 | [-7.82, -1.87] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
03d813a
to
fc9c88a
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=53963310 --os-family=ubuntu Note: This applies to commit f17462a |
fc9c88a
to
6a2e75d
Compare
6a2e75d
to
0b1da80
Compare
318e36a
to
f17462a
Compare
serverless test flake is a known issue: https://dd.slack.com/archives/CKJAXN89L/p1737749071355819?thread_ts=1737748986.020649&cid=CKJAXN89L |
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
Devflow running:
|
Devflow running:
|
f17462a
to
6b492c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
sets actual published modules as datadog-agent refs in go.mod files. also updates one collector file that was missed on last dep upgrade
Motivation
attempt to update deps in datadogexporter fails on non-existent module refs in go.mod files
Describe how you validated your changes
ran local go tests on all affected modules (pre-commit hooks). Will also ensure pipeline ci build/test passes.
Possible Drawbacks / Trade-offs
importing these modules in external code will depend on a newer version (v0.64.0-devel), can downgrade these deps if necessary.
Additional Notes
This should NOT change any functionality or APIs internal to the Datadog Agent; all datadog agent modules are replaced in go.mod files. This will only impact external repos importing datadog-agent (on which the OTel components rely heavily).