Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTEL-2396] remove non-existent module references #33376

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jackgopack4
Copy link
Contributor

@jackgopack4 jackgopack4 commented Jan 24, 2025

What does this PR do?

sets actual published modules as datadog-agent refs in go.mod files. also updates one collector file that was missed on last dep upgrade

Motivation

attempt to update deps in datadogexporter fails on non-existent module refs in go.mod files

Describe how you validated your changes

ran local go tests on all affected modules (pre-commit hooks). Will also ensure pipeline ci build/test passes.

Possible Drawbacks / Trade-offs

importing these modules in external code will depend on a newer version (v0.64.0-devel), can downgrade these deps if necessary.

Additional Notes

This should NOT change any functionality or APIs internal to the Datadog Agent; all datadog agent modules are replaced in go.mod files. This will only impact external repos importing datadog-agent (on which the OTel components rely heavily).

@jackgopack4 jackgopack4 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 24, 2025
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Jan 24, 2025
@jackgopack4 jackgopack4 added this to the 7.64.0 milestone Jan 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 24, 2025

Uncompressed package size comparison

Comparison with ancestor cd756b366767f0af66f7d17b0a4256eae1929871

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 916.09MB 916.09MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.09MB 59.09MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.50MB 56.50MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.89MB 477.89MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.88MB 93.88MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.95MB 93.95MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.93MB 89.93MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.00MB 90.00MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 925.81MB 925.81MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 938.66MB 938.66MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 938.66MB 938.66MB 0.50MB
datadog-agent-amd64-deb -0.00MB 928.92MB 928.92MB 0.50MB

Decision

✅ Passed

@jackgopack4 jackgopack4 marked this pull request as ready for review January 24, 2025 18:10
@jackgopack4 jackgopack4 requested review from a team, jeremy-hanna and IbraheemA and removed request for a team January 24, 2025 18:11
Copy link
Contributor Author

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually added all teams affected (since it is only go.mod files, no one was notified)

Copy link

cit-pr-commenter bot commented Jan 24, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 118774aa-78ab-4aae-bceb-515dcf17a7fc

Baseline: cd756b3
Comparison: 6b492c5
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +0.94 [+0.16, +1.73] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.79 [+0.72, +0.85] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.54 [-0.34, +1.43] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.19 [-0.28, +0.65] 1 Logs
quality_gate_idle_all_features memory utilization +0.17 [+0.12, +0.21] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.75, +0.84] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.77, +0.79] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.92, +0.93] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.90, +0.91] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.28, +0.26] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.89, +0.84] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.03 [-0.67, +0.60] 1 Logs
file_tree memory utilization -0.25 [-0.29, -0.20] 1 Logs
quality_gate_idle memory utilization -0.44 [-0.48, -0.40] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -4.85 [-7.82, -1.87] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@jackgopack4 jackgopack4 requested a review from a team as a code owner January 24, 2025 18:43
@jackgopack4 jackgopack4 force-pushed the jackgopack4/fix-go-mod-versions branch from 03d813a to fc9c88a Compare January 24, 2025 18:56
@jackgopack4 jackgopack4 marked this pull request as draft January 24, 2025 19:18
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 24, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53963310 --os-family=ubuntu

Note: This applies to commit f17462a

@jackgopack4 jackgopack4 force-pushed the jackgopack4/fix-go-mod-versions branch from fc9c88a to 6a2e75d Compare January 24, 2025 19:33
@jackgopack4 jackgopack4 force-pushed the jackgopack4/fix-go-mod-versions branch from 6a2e75d to 0b1da80 Compare January 24, 2025 19:33
@jackgopack4 jackgopack4 force-pushed the jackgopack4/fix-go-mod-versions branch 3 times, most recently from 318e36a to f17462a Compare January 24, 2025 20:22
@jackgopack4
Copy link
Contributor Author

@jackgopack4 jackgopack4 marked this pull request as ready for review January 24, 2025 20:24
@jackgopack4
Copy link
Contributor Author

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Jan 24, 2025

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2025-01-24 20:25:04 UTC ℹ️ Gitlab pipeline started

Started pipeline #53963310

@dd-devflow
Copy link

dd-devflow bot commented Jan 24, 2025

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2025-01-24 20:25:06 UTC ℹ️ Devflow: /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@jackgopack4 jackgopack4 force-pushed the jackgopack4/fix-go-mod-versions branch from f17462a to 6b492c5 Compare January 24, 2025 20:26
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 requested a review from ogaca-dd January 24, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants