Add OpenSearch to source identification #726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Chisamore <[email protected]>
schisamo
commented
Dec 20, 2023
| # e.g. /aws/OpenSearchService/domains/*/ES_APPLICATION_LOGS | ||
| # e.g. /aws/OpenSearchService/domains/*/AUDIT_LOGS | ||
| if log_group.startswith("/aws/opensearchservice/domains/"): | ||
| return "elasticsearch" |
There was a problem hiding this comment.
I'm not sure if the returned source should be elasticsearch or opensearch. I know from reading the docs Datadog knows how to parse ElasticSearch logs (assuming when source:elasticsearch is set on a log event) but I'm not sure if OpenSearch logs are different enough to need to parse differently (and if Datadog has some out of the box parsing rules for source:opensearch.
|
Is anyone watching MRs in this repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for identifying the source of OpenSearch logs from Cloudwatch log groups. More on OpenSearch logs can be found at: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/createdomain-configure-slow-logs.html
Motivation
If forwarded to Datadog, the source identification for these currently defaults to cloudwatch
Testing Guidelines
A new test has been added.
Additional Notes
I'm not sure if the returned source should be
elasticsearchoropensearch. I know from reading the docs Datadog knows how to parse ElasticSearch logs (assuming whensource:elasticsearchis set on a log event) but I'm not sure if OpenSearch logs are different enough to need to parse differently (and if Datadog has some out of the box parsing rules forsource:opensearch.Types of changes
Check all that apply