Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GuardDuty to S3 source parser #752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

loonydev
Copy link

What does this PR do?

Adding GuardDuty to possible source on S3 event.

Motivation

We are using S3 as our GuardDuty findings storage. Then, we trigger Lambda with a bucket notification.
Unfortunately, source was not parsed correctly and was left as source:s3

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@loonydev loonydev requested a review from a team as a code owner March 21, 2024 10:06
@loonydev loonydev force-pushed the feat/adding-guardduty-source-s3 branch from 6f4324d to 7c017c9 Compare March 22, 2024 09:22
Copy link
Contributor

@ge0Aja ge0Aja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't available as a source before refactoring the S3 handler
LGTM

@loonydev
Copy link
Author

loonydev commented Apr 2, 2024

@ge0Aja Could I get approval for the CI workflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants