V4.45.0 proposal #4591

uurien · 2024-08-09T15:27:35Z

Fixes

[core] Fix ALS continuation bug in body-parser (Fix ALS continuation bug in body-parser #4582)
[core] Correctly handle 128 bits traceids in log injection (correctly handle 128 bit traceids in log injection #4601)
[core] Update TraceProvider Constructors Typings (Update TraceProvider Constructors Typings #4596)
[iast] Fix bug with template literals (Update native-iast-rewriter to fix bug with template literals #4584)

Improvements

[test-visibility] Add compatibility with nyc's all input ([test-visibility] Add compatibility with nyc's all input #4568)
[test visibility] Add total code coverage measure to vitest ([test visibility] Add total code coverage measure to vitest #4570)
[core] Revise OTel Context and API Implementation To Enable OTel Auto Instrumentation Support (Revise OTel Context and API Implementation To Enable OTel Auto Instrumentation Support #4554)
[core] Ensure require-package-json is called with try-catch (ensure require-package-json is called with try-catch #4587)
[core] Add missing configuration values to telemetry (Add missing configuration values to telemetry #4580)
[iast] Support linuxmusl-arm64 in iast (Update @datadog/native-iast-taint-tracking to 3.1.0 to support linuxmusl-arm64 #4567)

Not to add in release notes

[332b216] - (SEMVER-PATCH) Run onboarding tests with and without profiling (Laplie Anderson) Run onboarding tests with and without profiling #4572 -> ignored because seems only internal CI change
[3e690eb] - (SEMVER-PATCH) use SSI variables on release builds (Bryan English) use SSI variables in CI #4571 -> ignored because seems only internal change
[79481ad] - (SEMVER-PATCH) Add CI options to prepare and merge release branches (Ugaitz Urien) Add CI options to prepare and merge release branches #4548 -> Only internal CI change
[483cac2] - (SEMVER-PATCH) simplify github actions for plugins (Bryan English) simplify github actions for plugins #4547 -> Seems only internal CI change (conflict)
[77be807] - (SEMVER-PATCH) Fix release proposal ci (Ugaitz Urien) Fix release proposal ci #4589 -> ignored because seems only internal CI change

github-actions · 2024-08-09T15:29:07Z

Overall package size

Self size: 6.94 MB
Deduped: 60.01 MB
No deduping: 60.29 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

…usl-arm64 (#4567)

…mentation Support (#4554) * rework otel context & api implementation to align more closely with dd-trace-py implementation in order to fix bug between otel express integration and dd-trace-js

* use SSI variables in CI * add SSI env var guards in guardrails tests * only run in SSI mode on release

)

pr-commenter · 2024-08-09T15:38:36Z

Benchmarks

Benchmark execution time: 2024-08-13 07:19:57

Comparing candidate commit 165f3cd in PR branch v4.45.0-proposal with baseline commit a2e575a in branch v4.x.

Found 1 performance improvements and 34 performance regressions! Performance is the same for 744 metrics, 19 unstable metrics.

scenario:appsec-appsec-enabled-18

🟥 cpu_user_time [+26.713ms; +34.705ms] or [+5.854%; +7.605%]

scenario:appsec-appsec-enabled-with-attacks-18

🟥 cpu_user_time [+25.185ms; +34.643ms] or [+5.144%; +7.076%]

scenario:appsec-control-18

🟥 cpu_user_time [+34.672ms; +42.168ms] or [+9.509%; +11.565%]
🟥 execution_time [+24.655ms; +50.683ms] or [+5.501%; +11.309%]
🟥 instructions [+50.0M instructions; +50.7M instructions] or [+5.787%; +5.868%]

scenario:appsec-control-20

🟥 instructions [+47.0M instructions; +49.8M instructions] or [+6.265%; +6.631%]

scenario:appsec-control-with-attacks-18

🟥 cpu_user_time [+27.851ms; +35.340ms] or [+8.037%; +10.199%]
🟥 instructions [+50.1M instructions; +50.7M instructions] or [+5.749%; +5.825%]

scenario:appsec-control-with-attacks-20

🟥 instructions [+48.1M instructions; +51.4M instructions] or [+6.343%; +6.779%]

scenario:log-skip-log-16

🟥 execution_time [+23.573ms; +24.296ms] or [+5.159%; +5.317%]

scenario:log-skip-log-18

🟥 execution_time [+27.728ms; +28.625ms] or [+5.515%; +5.694%]

scenario:log-skip-log-20

🟥 cpu_user_time [+32.049ms; +41.206ms] or [+9.616%; +12.364%]
🟥 execution_time [+32.385ms; +40.911ms] or [+8.662%; +10.942%]

scenario:log-with-debug-16

🟥 execution_time [+23.694ms; +24.470ms] or [+5.185%; +5.355%]

scenario:log-with-debug-18

🟥 execution_time [+28.158ms; +29.056ms] or [+5.606%; +5.785%]

scenario:log-with-debug-20

🟥 cpu_user_time [+30.828ms; +38.894ms] or [+9.298%; +11.731%]
🟥 execution_time [+33.395ms; +42.473ms] or [+8.898%; +11.316%]

scenario:log-with-error-16

🟥 execution_time [+23.914ms; +24.590ms] or [+5.234%; +5.382%]

scenario:log-with-error-18

🟥 execution_time [+27.627ms; +28.752ms] or [+5.497%; +5.721%]

scenario:log-with-error-20

🟥 cpu_user_time [+34.208ms; +43.665ms] or [+10.337%; +13.195%]
🟥 execution_time [+35.163ms; +44.020ms] or [+9.457%; +11.839%]

scenario:log-without-log-16

🟥 execution_time [+24.959ms; +26.400ms] or [+5.579%; +5.901%]

scenario:log-without-log-18

🟥 cpu_user_time [+24.649ms; +35.802ms] or [+5.596%; +8.128%]
🟥 execution_time [+28.758ms; +30.192ms] or [+5.910%; +6.204%]

scenario:log-without-log-20

🟥 cpu_user_time [+32.176ms; +41.540ms] or [+10.117%; +13.061%]
🟥 execution_time [+39.597ms; +47.842ms] or [+11.049%; +13.350%]

scenario:net-with-tracer-16

🟥 instructions [+47.4M instructions; +48.0M instructions] or [+5.528%; +5.608%]

scenario:net-with-tracer-18

🟥 instructions [+49.5M instructions; +49.9M instructions] or [+5.815%; +5.856%]

scenario:net-with-tracer-20

🟥 instructions [+50.2M instructions; +50.7M instructions] or [+6.260%; +6.314%]

scenario:plugin-bluebird-with-tracer-16

🟥 cpu_user_time [+24.321ms; +31.645ms] or [+5.125%; +6.668%]
🟥 execution_time [+31.387ms; +34.170ms] or [+6.020%; +6.554%]
🟥 instructions [+48.4M instructions; +49.7M instructions] or [+5.744%; +5.900%]

scenario:plugin-bluebird-with-tracer-18

🟥 instructions [+50.0M instructions; +51.2M instructions] or [+5.999%; +6.149%]

scenario:plugin-bluebird-with-tracer-20

🟥 instructions [+46.3M instructions; +48.7M instructions] or [+6.093%; +6.417%]

scenario:plugin-graphql-with-depth-and-collapse-off-18

🟩 max_rss_usage [-237.686MB; -233.154MB] or [-16.920%; -16.597%]

juan-fernandez

I removed two items from the release notes and it now looks good from test visibility's perspective. Thanks!

Co-authored-by: Ida Liu <[email protected]>

* update index.d.ts to include config object for TraceProvider constructor * update typing

uurien and others added 11 commits August 9, 2024 17:32

Update @datadog/native-iast-taint-tracking to 3.1.0 to support linuxm…

8597477

…usl-arm64 (#4567)

Add CI options to prepare and merge release branches (#4548)

10e27ae

Revise OTel Context and API Implementation To Enable OTel Auto Instru…

217011c

…mentation Support (#4554) * rework otel context & api implementation to align more closely with dd-trace-py implementation in order to fix bug between otel express integration and dd-trace-js

use SSI variables on release builds (#4571)

8b9d7d6

* use SSI variables in CI * add SSI env var guards in guardrails tests * only run in SSI mode on release

[test visibility] Add total code coverage measure to vitest (#4570)

ca60ae8

Run onboarding tests with and without profiling (#4572)

dae198b

[test-visibility] Add compatibility with nyc's all input (#4568)

516b16c

Update native-iast-rewriter to fix bug with template literals (#4584)

0304f18

[test-visibility] Update telemetry for test visibility (#4575)

0555153

Fix ALS continuation bug in body-parser (#4582)

b140e3a

[test visibility] Add check to determine whether git is available (#4588

b0c45a3

)

uurien force-pushed the v4.45.0-proposal branch from aec3d87 to b0c45a3 Compare August 9, 2024 15:32

Fix yarn.lock

91d1318

uurien force-pushed the v4.45.0-proposal branch from bf1e287 to 6786748 Compare August 12, 2024 07:25

uurien marked this pull request as ready for review August 12, 2024 07:39

uurien requested a review from a team as a code owner August 12, 2024 07:39

juan-fernandez previously approved these changes Aug 12, 2024

View reviewed changes

uurien and others added 7 commits August 13, 2024 09:00

Fix release proposal ci (#4589)

de4c647

Add missing configuration values to telemetry (#4580)

78ababb

Co-authored-by: Ida Liu <[email protected]>

ensure require-package-json is called with try-catch (#4587)

6565a07

Update TraceProvider Constructors Typings (#4596)

ebc396b

* update index.d.ts to include config object for TraceProvider constructor * update typing

simplify github actions for plugins (#4547)

dbdfaf0

correctly handle 128 bits traceids in log injection (#4601)

65379b4

v4.45.0

165f3cd

uurien dismissed juan-fernandez’s stale review via 165f3cd August 13, 2024 07:08

uurien force-pushed the v4.45.0-proposal branch from 6786748 to 165f3cd Compare August 13, 2024 07:08

juan-fernandez approved these changes Aug 13, 2024

View reviewed changes

uurien merged commit 165f3cd into v4.x Aug 13, 2024
181 checks passed

uurien deleted the v4.45.0-proposal branch August 13, 2024 15:46

uurien temporarily deployed to npm August 13, 2024 15:46 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V4.45.0 proposal #4591

V4.45.0 proposal #4591

uurien commented Aug 9, 2024 •

edited

Loading

github-actions bot commented Aug 9, 2024 •

edited

Loading

pr-commenter bot commented Aug 9, 2024 •

edited

Loading

juan-fernandez left a comment

V4.45.0 proposal #4591

V4.45.0 proposal #4591

Conversation

uurien commented Aug 9, 2024 • edited Loading

Fixes

Improvements

Not to add in release notes

github-actions bot commented Aug 9, 2024 • edited Loading

Overall package size

pr-commenter bot commented Aug 9, 2024 • edited Loading

Benchmarks

scenario:appsec-appsec-enabled-18

scenario:appsec-appsec-enabled-with-attacks-18

scenario:appsec-control-18

scenario:appsec-control-20

scenario:appsec-control-with-attacks-18

scenario:appsec-control-with-attacks-20

scenario:log-skip-log-16

scenario:log-skip-log-18

scenario:log-skip-log-20

scenario:log-with-debug-16

scenario:log-with-debug-18

scenario:log-with-debug-20

scenario:log-with-error-16

scenario:log-with-error-18

scenario:log-with-error-20

scenario:log-without-log-16

scenario:log-without-log-18

scenario:log-without-log-20

scenario:net-with-tracer-16

scenario:net-with-tracer-18

scenario:net-with-tracer-20

scenario:plugin-bluebird-with-tracer-16

scenario:plugin-bluebird-with-tracer-18

scenario:plugin-bluebird-with-tracer-20

scenario:plugin-graphql-with-depth-and-collapse-off-18

juan-fernandez left a comment

Choose a reason for hiding this comment

uurien commented Aug 9, 2024 •

edited

Loading

github-actions bot commented Aug 9, 2024 •

edited

Loading

pr-commenter bot commented Aug 9, 2024 •

edited

Loading