add Offline Cores #5
Open
+265
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanaobrien
requested changes
Dec 26, 2024
|
I don't even know how that happened vscode must have auto formatted it. |
|
I'm going to have to force push to fix it ug |
ethanaobrien
requested changes
Dec 27, 2024
|
|
ethanaobrien
requested changes
Dec 27, 2024
|
|
ethanaobrien
requested changes
Dec 28, 2024
Comment on lines
+354
to
+358
| urlsToCache.push(corePath + "reports/" + core.value + ".json"); | ||
| urlsToCache.push(corePath + core.value + "-wasm.data"); | ||
| urlsToCache.push(corePath + core.value + "-thread-wasm.data"); | ||
| urlsToCache.push(corePath + core.value + "-legacy-wasm.data"); | ||
| urlsToCache.push(corePath + core.value + "-thread-legacy-wasm.data"); |
There was a problem hiding this comment.
There should be some sort of opt-in here. This is 4x the amount of needed storage to keep a core locally. A user isn't often going to be switching between these at all
| @@ -53,6 +81,10 @@ self.addEventListener("fetch", (event) => { | |||
| let url = (requestURL.hostname === "cdn.emulatorjs.org") ? event.request.url : requestURL.pathname; | |||
| const cache = await caches.open(CACHE_NAME); | |||
| if (requestURL.hostname === "cdn.emulatorjs.org" && !OFFLINE_FILES.includes(event.request.url)) { | |||
| const cachedResponse = await caches.match(event.request); | |||
| if (cachedResponse) { | |||
There was a problem hiding this comment.
At what point in the code is this cache updated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.