New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Refactor error and data access #2733

Open

pbk20191 wants to merge 2 commits into EsotericSoftware:4.2 from pbk20191:refactor-error_and_data_access

+95 −55

pbk20191 commented Jan 12, 2025

Declare SpineError

Declaring conformance of standard protocol Error to standard library type String is highly discouraged. So I created SpineError which can be used with the same syntax as before while using Explicit type.

Support URLSessionDownloadTask cancellation

URLSession async download does supports Task cancellation, while current implementation does not, this commit will support Task cancellation below iOS 15.0

refactor accessing binary or c-String memory region

current implementation may have dangling pointer and access pointer out of scope that the Swift guarantee.
casting Swift.String to NSString can cause implicit deep copy which is not needed.
According to the guideline, only access the pointer inside the scope is safe.
this pr, move the access to the Data, String memory, inside the block scope which is guaranteed to be safe.

pbk20191 added 2 commits

January 12, 2025 23:56


          implement safe bounded data Access and cancellation supporting URLSes…

…sion downloadTask


          declare specific SpineError type

bd0a305

declaring conformance to Error on String is discouraged, and Creating own Error type is recommended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet