CI Build changes #1362
Merged
CI Build changes #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: William Bohrmann <[email protected]> Co-authored-by: Andy Weis <[email protected]> Co-authored-by: Zack Allen <[email protected]> Co-authored-by: Morten Nielsen <[email protected]> Co-authored-by: William Bohrmann <[email protected]> Co-authored-by: Preeti <[email protected]> Co-authored-by: Morten Nielsen <[email protected]> Co-authored-by: Greg De Stigter <[email protected]> Co-authored-by: Teja Balu <[email protected]>
# Conflicts: # .github/workflows/Open_PR.yml # src/MAUI/Maui.Samples/Samples/Data/SymbolizeShapefile/SymbolizeShapefile.xaml # src/MAUI/Maui.Samples/Samples/Layers/AddClusteringFeatureReductionToAPointFeatureLayer/AddClusteringFeatureReductionToAPointFeatureLayer.xaml # src/MAUI/Maui.Samples/Samples/Layers/BrowseWfsLayers/BrowseWfsLayers.xaml # src/MAUI/Maui.Samples/Samples/Layers/ChangeSublayerRenderer/ChangeSublayerRenderer.xaml # src/MAUI/Maui.Samples/Samples/Layers/RasterRenderingRule/RasterRenderingRule.xaml # src/MAUI/Maui.Samples/Samples/Location/ShowLocationHistory/ShowLocationHistory.xaml # src/MAUI/Maui.Samples/Samples/Map/OpenMapURL/OpenMapURL.xaml # src/MAUI/Maui.Samples/Samples/MapView/ChangeViewpoint/ChangeViewpoint.xaml # src/MAUI/Maui.Samples/Samples/MapView/TakeScreenshot/TakeScreenshot.xaml # src/MAUI/Maui.Samples/Samples/SceneView/ChooseCameraController/ChooseCameraController.xaml # src/MAUI/Maui.Samples/Samples/Symbology/FeatureLayerExtrusion/FeatureLayerExtrusion.xaml # src/WPF/WPF.Viewer/ArcGIS.WPF.Viewer.Net.csproj # src/WPF/WPF.Viewer/Samples/Layers/AddClusteringFeatureReductionToAPointFeatureLayer/AddClusteringFeatureReductionToAPointFeatureLayer.xaml # src/WinUI/ArcGIS.WinUI.Viewer/Samples/Layers/AddClusteringFeatureReductionToAPointFeatureLayer/AddClusteringFeatureReductionToAPointFeatureLayer.xaml
|
@dotMorten can you cherry-pick the commits specific for this PR into a new branch based off updated main? There are old v.next commits which are not present in our main branch due our PR bringing v.next into main at program increment 3, 2023. Although the files changed look good, I'd prefer to keep our commit history as is. |
There was a problem hiding this comment.
Thank you for completing this work. Three suggestions:
- Cleaned up commit history for your branch for sake of PR cleanliness.
- Class rename.
- Investigate why the .NET MAUI build failed for our build check job triggered by PRs: https://github.com/Esri/arcgis-maps-sdk-dotnet-samples/blob/main/.github/workflows/BuildSuccess_Check.yaml#L27
duffh
reviewed
Jan 8, 2024
There was a problem hiding this comment.
Looks good to me but I'm seeing the following error in our MAUI build action.
"D:\a\arcgis-maps-sdk-dotnet-samples\arcgis-maps-sdk-dotnet-samples\src\MAUI\ArcGIS.Samples.MAUI.sln" (Build target) (1:2) ->
"D:\a\arcgis-maps-sdk-dotnet-samples\arcgis-maps-sdk-dotnet-samples\src\MAUI\Maui.Samples\ArcGIS.Samples.Maui.csproj" (default target) (2:22) ->
"D:\a\arcgis-maps-sdk-dotnet-samples\arcgis-maps-sdk-dotnet-samples\src\MAUI\Maui.Samples\ArcGIS.Samples.Maui.csproj" (Build target) (2:32) ->
(ResolveReadyToRunCompilers target) ->
C:\Program Files\dotnet\sdk\8.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(396,5): error NETSDK1094: Unable to optimize assemblies for performance: a valid runtime package was not found. Either set the PublishReadyToRun property to false, or use a supported runtime identifier when publishing. When targeting .NET 6 or higher, make sure to restore packages with the PublishReadyToRun property set to true. [D:\a\arcgis-maps-sdk-dotnet-samples\arcgis-maps-sdk-dotnet-samples\src\MAUI\Maui.Samples\ArcGIS.Samples.Maui.csproj::TargetFramework=net8.0-windows10.0.19041.0]
Do we need to update the script or is this an issue introduced by the updated MAUI project file?
|
No need to clean up commit history, everything will be squashed and merge in the end. |
williambohrmann3
approved these changes
Jan 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
Co-authored-by: Hamish Duff <[email protected]> Co-authored-by: William Bohrmann <[email protected]> Co-authored-by: Andy Weis <[email protected]> Co-authored-by: Zack Allen <[email protected]> Co-authored-by: William Bohrmann <[email protected]> Co-authored-by: Preeti <[email protected]> Co-authored-by: Greg De Stigter <[email protected]> Co-authored-by: Teja Balu <[email protected]> Co-authored-by: Morten Nielsen <[email protected]> Co-authored-by: Hamish Duff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the project and script changes to allow for daily CI builds
Type of change
Platforms tested on
Checklist