Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MAUI sample viewer search functionality #1372

Merged
merged 15 commits into from
Jan 19, 2024

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Jan 15, 2024

Description

  • Removed popup search view.
  • Updated search result UI.
  • Improved search result accuracy.

Type of change

  • Sample viewer enhancement

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the UI changes made. However, I am finding a bug that's been hard to reproduce. Sometimes, the screenshots aren't sized appropriately. Have you experienced this?
gWhBlJgpFr

Also, some of the search results seem too far removed from the search query. The term "create and edit geometries" for example. It might be worthwhile altering our scoring system.

@duffh
Copy link
Collaborator Author

duffh commented Jan 19, 2024

I really like the UI changes made. However, I am finding a bug that's been hard to reproduce. Sometimes, the screenshots aren't sized appropriately. Have you experienced this? gWhBlJgpFr

Also, some of the search results seem too far removed from the search query. The term "create and edit geometries" for example. It might be worthwhile altering our scoring system.

I haven't been able to replicate the screenshot size issue you're seeing.

What is wrong with the search results for "create and edit geometries"?

We return results based on key words found in the sample title, category, description and tags. Results that are far removed from the query will contain a subset of the searched keywords.

Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can later optimize search results if we choose

@duffh duffh merged commit f09ed43 into main Jan 19, 2024
6 checks passed
@duffh duffh deleted the hduff/update-search-popup-maui branch January 19, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants