Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.NET MAUI] Focus search bar automatically on search page #1491

Merged
merged 1 commit into from
Jul 24, 2024
Merged

[.NET MAUI] Focus search bar automatically on search page #1491

merged 1 commit into from
Jul 24, 2024

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Jul 23, 2024 •
edited
Loading

Description

It's a better experience to automatically have the search bar focused when navigating to the search page.

Type of change

  • Sample viewer enhancement

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

@duffh duffh self-assigned this Jul 23, 2024
williambohrmann3
williambohrmann3 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on maccatalyst and ios 👍

@duffh duffh merged commit 5d54ae2 into main Jul 24, 2024
6 checks passed
@duffh duffh deleted the hduff/focus-search-bar branch July 24, 2024 09:06
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@duffh @arcgis-maps-sdk-bot
[.NET MAUI] Focus search bar automatically on search page (#1491)
dec9364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williambohrmann3 williambohrmann3 williambohrmann3 approved these changes

@cgutierrez-gis cgutierrez-gis Awaiting requested review from cgutierrez-gis

Assignees

@duffh duffh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duffh @williambohrmann3