Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET MAUI] Updated samples using ListView and CollectionView with DataTemplate #1496

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Jul 25, 2024

Description

A .NET MAUI bug is preventing CollectionView and ListView content displaying in release configuration if the data type is not explicitly set on the DataTemplate.

This workaround didn't work for the Picker used in "Offline routing" so I replaced it with a CollectionView.

dotnet/maui#20002

Type of change

  • Bug fix

Platforms tested on

  • WPF .NET 8
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@duffh duffh self-assigned this Jul 25, 2024
also fixes bug in `CreateDynamicBasemapGallery` which causes app crash when no basemap style is selected
Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we figured out origin of this bug. Tested on Android simulator. I committed some fixes to CreateDynamicBasemapGallery so now sample is fully operational in Release config.

@duffh duffh merged commit df20e17 into v.next Jul 26, 2024
2 checks passed
@duffh duffh deleted the hduff/maui-datatemplate-bugfixes branch July 26, 2024 09:38
williambohrmann3 added a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants