Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
piket committed Nov 15, 2023
1 parent 2952357 commit 76134e6
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions sdk/python/tests/expediagroup/test_elasticsearch_online_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ def repo_config(embedded_elasticsearch):
endpoint=f"http://{embedded_elasticsearch['host']}:{embedded_elasticsearch['port']}",
username=embedded_elasticsearch["username"],
password=embedded_elasticsearch["password"],
token=embedded_elasticsearch["token"],
),
offline_store=FileOfflineStoreConfig(),
entity_key_serialization_version=2,
Expand Down Expand Up @@ -132,7 +131,7 @@ def test_elasticsearch_update_add_index(self, repo_config, caplog, index_params)
Field(name="feature10", dtype=UnixTimestamp),
]
ElasticsearchOnlineStore().update(
config=repo_config.online_store,
config=repo_config,
tables_to_delete=[],
tables_to_keep=[
FeatureView(
Expand Down Expand Up @@ -195,7 +194,7 @@ def test_elasticsearch_update_add_existing_index(self, repo_config, caplog):
]
self._create_index_in_es(self.index_to_write, repo_config)
ElasticsearchOnlineStore().update(
config=repo_config.online_store,
config=repo_config,
tables_to_delete=[],
tables_to_keep=[
FeatureView(
Expand Down Expand Up @@ -236,7 +235,7 @@ def test_elasticsearch_update_delete_index(self, repo_config, caplog):
assert es.indices.exists(index=self.index_to_delete).body is True

ElasticsearchOnlineStore().update(
config=repo_config.online_store,
config=repo_config,
tables_to_delete=[
FeatureView(
name=self.index_to_delete,
Expand Down Expand Up @@ -276,7 +275,7 @@ def test_elasticsearch_update_delete_unavailable_index(self, repo_config, caplog
assert es.indices.exists(index=self.index_to_delete).body is False

ElasticsearchOnlineStore().update(
config=repo_config.online_store,
config=repo_config,
tables_to_delete=[
FeatureView(
name=self.index_to_delete,
Expand Down Expand Up @@ -304,7 +303,7 @@ def test_elasticsearch_online_write_batch(self, repo_config, caplog):
n=total_rows_to_write,
)
ElasticsearchOnlineStore().online_write_batch(
config=repo_config.online_store,
config=repo_config,
table=feature_view,
data=data,
progress=None,
Expand Down Expand Up @@ -334,7 +333,7 @@ def test_elasticsearch_online_read(self, repo_config, caplog):
]
store = ElasticsearchOnlineStore()
store.online_write_batch(
config=repo_config.online_store,
config=repo_config,
table=feature_view,
data=data,
progress=None,
Expand All @@ -344,7 +343,7 @@ def test_elasticsearch_online_read(self, repo_config, caplog):
es.indices.refresh(index=self.index_to_read)

result = store.online_read(
config=repo_config.online_store,
config=repo_config,
table=feature_view,
entity_keys=ids,
)
Expand Down Expand Up @@ -376,7 +375,7 @@ def test_elasticsearch_online_read_with_requested_features(
]
store = ElasticsearchOnlineStore()
store.online_write_batch(
config=repo_config.online_store,
config=repo_config,
table=feature_view,
data=data,
progress=None,
Expand All @@ -386,7 +385,7 @@ def test_elasticsearch_online_read_with_requested_features(
es.indices.refresh(index=self.index_to_read)

result = store.online_read(
config=repo_config.online_store,
config=repo_config,
table=feature_view,
entity_keys=ids,
requested_features=requested_features,
Expand Down

0 comments on commit 76134e6

Please sign in to comment.