feat: Implement key batching for cassandra online store in go feature server. #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabhagwat
changed the title
zabarn
reviewed
Jan 22, 2025
Comment on lines
164
to
168
| if !ok { | ||
| keyBatchSize = 10.0 | ||
| log.Warn().Msg("key_batch_size not specified, defaulting to batches of size 10") | ||
| } | ||
| cassandraConfig.keyBatchSize = int(keyBatchSize.(float64)) |
There was a problem hiding this comment.
We might want a different default value
There was a problem hiding this comment.
Updated the default value to 5.
Limiting the keyBatchSize max to 100 since maximum clustering-key cartesian product size is 100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feat: Implement key batching for cassandra online store in go feature server.
Which issue(s) this PR fixes:
Misc