Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix elasticsearch connection manager calls #70

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

piket
Copy link
Collaborator

@piket piket commented Nov 15, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:
remove unneeded config value "token"
fix calls to eleasticsearch connection manager to use the online_store config

Copy link
Collaborator

@michaelbackes michaelbackes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piket piket merged commit 9ee716f into master Nov 15, 2023
17 checks passed
@piket piket deleted the fix_elasticsearch branch November 15, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants