Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KafkaSourceModel to Pydantic models #72

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

expediamatt
Copy link

This PR adds KafkaSourceModel to Pydantic models, making KafkaSources viable data sources for transmission in service calls such as the ones in Registry Service.

https://jira.expedia.biz/browse/EAPC-9689

Copy link

@wparsley-eg wparsley-eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@expediamatt expediamatt merged commit 5a7db83 into master Dec 4, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants