Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simulation support to FalconEncoder and FalconMotor. #114

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add simulation support to FalconEncoder and FalconMotor. #114

wants to merge 12 commits into from

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Apr 15, 2020 •
edited
Loading

This adds support for simulating the position, velocity and voltage outputs of FalconEncoder and FalconMotor. The sim device name is customized by each of their subclasses.

  • Sim position support
  • Sim velocity support
  • Sim voltage support

@prateekma prateekma requested a review from Goobwabber April 15, 2020 02:21
@mcm001
Copy link
Contributor Author

mcm001 commented Apr 15, 2020

Screenshot_20200414-221144
Still working on showing the units next to falcon encoder. Would love feedback on the API.

@mcm001 mcm001 marked this pull request as ready for review April 15, 2020 19:23
@mcm001 mcm001 changed the title [WIP] Add simulation support to FalconEncoder and FalconMotor. Add simulation support to FalconEncoder and FalconMotor. Apr 15, 2020
@mcm001
Copy link
Contributor Author

mcm001 commented Apr 15, 2020

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goobwabber Goobwabber Awaiting requested review from Goobwabber

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcm001