Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FPS Option #2602

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Add FPS Option #2602

merged 3 commits into from
Oct 1, 2024

Conversation

lemz1
Copy link
Contributor

@lemz1 lemz1 commented May 24, 2024 •
edited
Loading

Additions

  • fps option which goes from 60 to 360

TODO

PREVIEW

fps.preview.mp4

@lemz1 lemz1 marked this pull request as draft May 24, 2024 23:14
@lemz1 lemz1 marked this pull request as ready for review May 25, 2024 00:19
@lemz1 lemz1 changed the title Add FPS Option [FEATURE] Add FPS Option May 25, 2024
@EliteMasterEric EliteMasterEric added the type: enhancement Involves an enhancement or new feature. label May 30, 2024
@Bezizeja
Copy link

Bezizeja commented Jun 9, 2024

have it go up to 360 fps

@charlesisfeline
Copy link

charlesisfeline commented Jun 10, 2024 •
edited
Loading

have it go up to 360 fps

nuh uh, capped to 1440

@lemz1
Copy link
Contributor Author

lemz1 commented Jun 10, 2024

have it go up to 360 fps

its already capped at 360

@EliteMasterEric EliteMasterEric added the status: pending triage Awaiting review. label Jun 17, 2024
@EliteMasterEric
Copy link
Member

Note, might conflict with #2793

@EliteMasterEric EliteMasterEric added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Jun 17, 2024
@EliteMasterEric EliteMasterEric mentioned this pull request Jun 17, 2024
Closed
2 tasks
@lemz1 lemz1 changed the title [FEATURE] Add FPS Option Add FPS Option Jun 22, 2024
@lemz1
Copy link
Contributor Author

lemz1 commented Jun 23, 2024

Note, might conflict with #2793

This shouldnt conflict with #2793 anymore

@lemz1 lemz1 mentioned this pull request Jun 30, 2024
Closed
@EliteMasterEric EliteMasterEric added the size: medium A medium pull request with 100 or fewer changes. label Jul 11, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Sep 13, 2024 •
edited
Loading

v0.5.0 has an "Unlocked Framerate" option now.

UPDATE: It seems to be in Web only? I checked the itch build.

@EliteMasterEric
Copy link
Member

Unlocked framerate is a web only thing

v0.5 has support for numeric options so adding an FPS limit option to desktop would be great

@EliteMasterEric EliteMasterEric mentioned this pull request Sep 17, 2024
Closed
2 tasks
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Sep 18, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 18, 2024
@EliteMasterEric EliteMasterEric self-assigned this Sep 19, 2024
@EliteMasterEric EliteMasterEric merged commit d417faf into FunkinCrew:develop Oct 1, 2024
@Bezizeja
Copy link

Bezizeja commented Oct 4, 2024

so i got the 0.5.1 version that has this implementation if you put above 165fps game is not smooth at all and feels really weird i have 240hz monitor and it doesnt utilise it

@lemz1
Copy link
Contributor Author

lemz1 commented Oct 4, 2024 •
edited
Loading

can you elaborate?

do you actually get 240 fps?
maybe your pc cant reach 240fps in fnf

@Bezizeja
Copy link

Bezizeja commented Oct 4, 2024

oh wait nvm it is smooth everything good

@Hundrec Hundrec added the pr: haxe PR modifies game code. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
6 participants
@lemz1 @Bezizeja @charlesisfeline @EliteMasterEric @AbnormalPoof @Hundrec