[ENHANCEMENT] Frames/Grouped Fields in Events #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: medium
|
wait shit i forgot about loading the events uhhh gimme a minute edit: "fixed" it (its literally due to that one bug that i fixed in a previous pr fml), also why does github actions immidiately remove the size label this is for my 2nd pr in a row does the bot not like my prs,,,,, |
github-actions
bot
added
size: medium
Hundrec
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
2876 shoutouts hundrec for pointing out the issue alongside others closed by linear
Briefly describe the issue(s) fixed.
had to change the grid to a vbox w/ hboxes sorry eric the frames didn't look good otherwise
anyways frames!!! they have a field called "children" where you put in SongEventFields and then those fields get rendered inside the frames
Include any relevant screenshots or videos.
Toolbox
Fucked up JSON w/ the fields
How they're added
Recursive Frames because it was funny (takes a bit to load them though!)
