Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Smoother Health Bar and use OUTLINE_FAST for Score Text Outline [FIXED] #4021

Closed
wants to merge 20 commits into from

Conversation

CyndaReal
Copy link

This is a redo of PR #3680 because I accidentally pressed force push and broke it, whoops! Same ordeal.

below is the original description:

The healthbar is currently choppy, and doesn't smoothly line up with the lerp and health icon positions. This fixes this by giving the healthbar the same number of divisions as its width in pixels (effectively the maximum that fit in the space of the healthbar).

This PR also switches the FlxTextBorderStyle of scoreText from OUTLINE to OUTLINE_FAST, which is not noticeable visually (especially with the pixel font that scoreText uses) and is slightly more optimized.

EliteMasterEric and others added 20 commits October 11, 2024 23:57
* changelog sweep

* Resolve a few conflicts

* Resolve more conflicts

* DadBattle

* Re-add @ianharrigan

* Add links to 0.5.0

* Add links and contributors to 0.4.1 and 0.4.0

* Add links to 0.3.3 and finishing touches

* Add and polish 0.5.3 changes

* Make spacing consistent
* Make label actions more convenient

* chore: Add status: planned to label actions
… by default (this re-enables the Stage Editor keybind).
… to 0.5.3) (FunkinCrew#3834)

* Create Charting Issue template

* Include images and videos in charting issue template

* Update version in bug report template

* Update version in crash report template
* Create compiling.yml

* Update compiling.yml

* Update compiling.yml

* Update compiling.yml

* Update compiling.yml

* Update compiling.yml

* charting (Hundrec)

thanks hundrec i like this

* Delete .github/ISSUE_TEMPLATE/charting.yml
@CyndaReal CyndaReal changed the base branch from main to develop January 22, 2025 20:53
@github-actions github-actions bot added pr: haxe PR modifies game code. pr: documentation PR modifies documentation or README files. size: large A large pull request with more than 100 changes. labels Jan 22, 2025
@CyndaReal
Copy link
Author

ignore all that, its just stuff from Main thats not in develop right now

@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. topic: polish Involves minor polish to the UI or gameplay. size: medium A medium pull request with 100 or fewer changes. and removed size: large A large pull request with more than 100 changes. pr: documentation PR modifies documentation or README files. labels Jan 22, 2025
@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Jan 22, 2025
@AbnormalPoof
Copy link
Collaborator

You should probably rebase to remove the extra commits from main.

@CyndaReal
Copy link
Author

how

@CyndaReal
Copy link
Author

Sorry for the hassle, I'm just gonna redo this again based on develop instead of main.

@CyndaReal CyndaReal closed this Jan 24, 2025
@CyndaReal CyndaReal deleted the bar-divisions-taketwo branch January 24, 2025 13:06
@AbnormalPoof AbnormalPoof added status: rejected Issue did not pass review or PR cannot be approved. and removed type: enhancement Involves an enhancement or new feature. topic: polish Involves minor polish to the UI or gameplay. status: needs revision Cannot be approved because it is awaiting some work by the contributor. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants