-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Smoother Health Bar and use OUTLINE_FAST for Score Text Outline [FIXED] #4021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changelog sweep * Resolve a few conflicts * Resolve more conflicts * DadBattle * Re-add @ianharrigan * Add links to 0.5.0 * Add links and contributors to 0.4.1 and 0.4.0 * Add links to 0.3.3 and finishing touches * Add and polish 0.5.3 changes * Make spacing consistent
* Make label actions more convenient * chore: Add status: planned to label actions
… by default (this re-enables the Stage Editor keybind).
… to 0.5.3) (FunkinCrew#3834) * Create Charting Issue template * Include images and videos in charting issue template * Update version in bug report template * Update version in crash report template
* Create compiling.yml * Update compiling.yml * Update compiling.yml * Update compiling.yml * Update compiling.yml * Update compiling.yml * charting (Hundrec) thanks hundrec i like this * Delete .github/ISSUE_TEMPLATE/charting.yml
github-actions
bot
added
pr: haxe
PR modifies game code.
pr: documentation
PR modifies documentation or README files.
size: large
A large pull request with more than 100 changes.
labels
Jan 22, 2025
ignore all that, its just stuff from Main thats not in develop right now |
Hundrec
added
type: enhancement
Involves an enhancement or new feature.
topic: polish
Involves minor polish to the UI or gameplay.
size: medium
A medium pull request with 100 or fewer changes.
and removed
size: large
A large pull request with more than 100 changes.
pr: documentation
PR modifies documentation or README files.
labels
Jan 22, 2025
AbnormalPoof
added
status: pending triage
Awaiting review.
status: needs revision
Cannot be approved because it is awaiting some work by the contributor.
and removed
status: pending triage
Awaiting review.
labels
Jan 22, 2025
You should probably rebase to remove the extra commits from |
how |
Sorry for the hassle, I'm just gonna redo this again based on develop instead of main. |
AbnormalPoof
added
status: rejected
Issue did not pass review or PR cannot be approved.
and removed
type: enhancement
Involves an enhancement or new feature.
topic: polish
Involves minor polish to the UI or gameplay.
status: needs revision
Cannot be approved because it is awaiting some work by the contributor.
size: medium
A medium pull request with 100 or fewer changes.
pr: haxe
PR modifies game code.
labels
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of PR #3680 because I accidentally pressed force push and broke it, whoops! Same ordeal.
below is the original description:
The healthbar is currently choppy, and doesn't smoothly line up with the lerp and health icon positions. This fixes this by giving the healthbar the same number of divisions as its width in pixels (effectively the maximum that fit in the space of the healthbar).
This PR also switches the FlxTextBorderStyle of scoreText from OUTLINE to OUTLINE_FAST, which is not noticeable visually (especially with the pixel font that scoreText uses) and is slightly more optimized.