angry senpai fix #111
Open
angry senpai fix #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hundrec
added
status: pending triage
|
i think im sure they probably got this fixed for the next update already, i dont think i really see the point of making this pr- |
|
The Roses cutscene fix is already implemented in #24 |
AbnormalPoof
added
status: needs revision
|
Oops |
|
Wait so uh, there's already a pull on this, but it hasn't already been implemented? Also I just realized I didn't remove the music for the alternative roses dialogue. Should I just close this PR? Nvm, I looked at the other PR and it doesn't do the same stuff. |
|
Also, if you're wondering why I have two sounds play, that's because it's what the previous engine version does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Briefly describe the issue(s) fixed.
The current version of senpai getting angry is sort of broken - it doesn't pan to senpai before the roses song, it doesn't play the angry text sound, the animation of the dialogue box is sped up too fast and the UI kind of distracts from the scene altogether (that, and it plays the dialogue music too???)
Include any relevant screenshots or videos.
Previous engine version:
2025-01-28.22-17-31.mp4
(video is of psych engine, but it should still be applicable of course)
Current version
2025-01-28.22-13-15.mp4
Fixed version
2025-01-29.02-30-57.mp4
This pull request needs to happen with the no dialogue music crash fix, otherwise after the conversation finishes, it will crash.
Also, yay, first pull request (and hopefully not the last/only one too?)