Remove explicit "overflow: 'visible'"

GMOD · Apr 12, 2024 · 1b0f3be · 1b0f3be
1 parent 6e0d5dd
commit 1b0f3be
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 14 deletions.
diff --git a/packages/app-core/src/ui/App/ViewContainer.tsx b/packages/app-core/src/ui/App/ViewContainer.tsx
@@ -16,10 +16,6 @@ const useStyles = makeStyles()(theme => ({
   viewContainer: {
     margin: theme.spacing(0.5),
     padding: `0 ${theme.spacing(1)} ${theme.spacing(1)}`,
-    overflow: 'visible',
-  },
-  viewContentsContainer: {
-    overflow: 'visible',
   },
   focusedView: {
     background: theme.palette.secondary.main,
@@ -75,7 +71,7 @@ const ViewContainer = observer(function ({
           onMinimize={() => view.setMinimized(!view.minimized)}
           className={backgroundColorClassName}
         />
-        <Paper elevation={0} className={classes.viewContentsContainer}>
+        <Paper elevation={0}>
           <ViewWrapper view={view} session={session} />
         </Paper>
       </Paper>

diff --git a/plugins/linear-genome-view/src/LinearGenomeView/components/LinearGenomeView.tsx b/plugins/linear-genome-view/src/LinearGenomeView/components/LinearGenomeView.tsx
@@ -40,7 +40,6 @@ const useStyles = makeStyles()(theme => ({
   },
   rel: {
     position: 'relative',
-    overflow: 'visible',
   },
   top: {
     zIndex: 1000,

diff --git a/plugins/linear-genome-view/src/LinearGenomeView/components/RubberbandSpan.tsx b/plugins/linear-genome-view/src/LinearGenomeView/components/RubberbandSpan.tsx
@@ -15,7 +15,6 @@ const useStyles = makeStyles()(theme => {
       position: 'absolute',
       zIndex: 4,
       textAlign: 'center',
-      overflow: 'visible',
     },
     rubberbandControl: {
       cursor: 'crosshair',

diff --git a/plugins/linear-genome-view/src/LinearGenomeView/components/TracksContainer.tsx b/plugins/linear-genome-view/src/LinearGenomeView/components/TracksContainer.tsx
@@ -20,7 +20,6 @@ import HighlightGroup from './Highlight'
 const useStyles = makeStyles()({
   tracksContainer: {
     position: 'relative',
-    overflow: 'visible',
   },
 })
 

diff --git a/...-genome-view/src/LinearGenomeView/components/__snapshots__/LinearGenomeView.test.tsx.snap b/...-genome-view/src/LinearGenomeView/components/__snapshots__/LinearGenomeView.test.tsx.snap
@@ -3,7 +3,7 @@
 exports[`renders one track, one region 1`] = `
 <div>
   <div
-    class="css-12nbmo-rel"
+    class="css-1v4ghfe-rel"
   >
     <div
       class="css-1qdjf66-header"
@@ -330,7 +330,7 @@ exports[`renders one track, one region 1`] = `
       </div>
     </div>
     <div
-      class="css-6g5kqy-tracksContainer"
+      class="css-1x918n3-tracksContainer"
       data-testid="tracksContainer"
     >
       <div
@@ -620,7 +620,7 @@ exports[`renders one track, one region 1`] = `
 exports[`renders two tracks, two regions 1`] = `
 <div>
   <div
-    class="css-12nbmo-rel"
+    class="css-1v4ghfe-rel"
   >
     <div
       class="css-1qdjf66-header"
@@ -965,7 +965,7 @@ exports[`renders two tracks, two regions 1`] = `
       </div>
     </div>
     <div
-      class="css-6g5kqy-tracksContainer"
+      class="css-1x918n3-tracksContainer"
       data-testid="tracksContainer"
     >
       <div

diff --git a/...nome-view/src/JBrowseLinearGenomeView/__snapshots__/JBrowseLinearGenomeView.test.tsx.snap b/...nome-view/src/JBrowseLinearGenomeView/__snapshots__/JBrowseLinearGenomeView.test.tsx.snap
@@ -86,7 +86,7 @@ exports[`<JBrowseLinearGenomeView /> renders successfully 1`] = `
           class="MuiPaper-root MuiPaper-elevation MuiPaper-rounded MuiPaper-elevation1 css-1ps6pg7-MuiPaper-root"
         >
           <div
-            class="css-12nbmo-rel"
+            class="css-1v4ghfe-rel"
           >
             <div
               class="css-1qdjf66-header"
@@ -421,7 +421,7 @@ exports[`<JBrowseLinearGenomeView /> renders successfully 1`] = `
               </div>
             </div>
             <div
-              class="css-6g5kqy-tracksContainer"
+              class="css-1x918n3-tracksContainer"
               data-testid="tracksContainer"
             >
               <div
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,7 +40,6 @@ const useStyles = makeStyles()(theme => ({ @@
       },
       rel: {
         position: 'relative',
-        overflow: 'visible',
       },
       top: {
         zIndex: 1000,
@@ Expand Down @@