Rename APIs for feature density stats and quantitative stats (#3618)

packages/core/TextSearch/TextSearchManager.ts

@@ -1,17 +1,12 @@
 import BaseResult from './BaseResults'
 import PluginManager from '../PluginManager'
 import QuickLRU from '../util/QuickLRU'
-import { SearchType, BaseTextSearchAdapter } from '../data_adapters/BaseAdapter'
+import {
+  BaseTextSearchAdapter,
+  BaseTextSearchArgs,
+} from '../data_adapters/BaseAdapter'
 import { readConfObject, AnyConfigurationModel } from '../configuration'
 
-export interface BaseArgs {
-  queryString: string
-  searchType?: SearchType
-  signal?: AbortSignal
-  limit?: number
-  pageNumber?: number
-}
-
 export interface SearchScope {
   includeAggregateIndexes: boolean
   assemblyName: string
@@ -91,7 +86,7 @@ export default class TextSearchManager {
    * limit of results to return, searchType...prefix | full | exact", etc.
    */
   async search(
-    args: BaseArgs,
+    args: BaseTextSearchArgs,
     searchScope: SearchScope,
     rankFn: (results: BaseResult[]) => BaseResult[],
   ) {

packages/core/assemblyManager/assembly.ts

@@ -5,6 +5,7 @@ import AbortablePromiseCache from 'abortable-promise-cache'
 // locals
 import { getConf, AnyConfigurationModel } from '../configuration'
 import {
+  BaseOptions,
   BaseRefNameAliasAdapter,
   RegionsAdapter,
 } from '../data_adapters/BaseAdapter'
@@ -111,12 +112,6 @@ function getAdapterId(adapterConf: unknown) {
 
 type RefNameAliases = Record<string, string>
 
-export interface BaseOptions {
-  signal?: AbortSignal
-  sessionId: string
-  statusCallback?: Function
-}
-
 interface CacheData {
   adapterConf: unknown
   self: Assembly
@@ -148,10 +143,12 @@ export default function assemblyFactory(
 ) {
   const adapterLoads = new AbortablePromiseCache<CacheData, RefNameMap>({
     cache: new QuickLRU({ maxSize: 1000 }),
+
+    // @ts-expect-error
     async fill(
       args: CacheData,
       signal?: AbortSignal,
-      statusCallback?: Function,
+      statusCallback?: (arg: string) => void,
     ) {
       const { adapterConf, self, options } = args
       return loadRefNameMap(