Copy view

GMOD · Jan 25, 2025 · 3bff8d1 · 3bff8d1
1 parent 73b24f4
commit 3bff8d1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/packages/app-core/src/ui/App/ViewMenu.tsx b/packages/app-core/src/ui/App/ViewMenu.tsx
@@ -12,6 +12,7 @@ import {
   usePopupState,
 } from 'material-ui-popup-state/hooks'
 import { observer } from 'mobx-react'
+import { getSnapshot } from 'mobx-state-tree'
 
 import type { IBaseViewModel } from '@jbrowse/core/pluggableElementTypes/models'
 import type { AbstractSessionModel } from '@jbrowse/core/util'
@@ -108,6 +109,13 @@ const ViewMenu = observer(function ({
                 },
               ]
             : []),
+          {
+            label: 'Copy view',
+            onClick: () => {
+              const { id, ...rest } = getSnapshot(model)
+              session.addView(model.type, rest)
+            },
+          },
           ...model.menuItems(),
         ]}
         popupState={popupState}

diff --git a/packages/app-core/src/ui/App/ViewPanel.tsx b/packages/app-core/src/ui/App/ViewPanel.tsx
@@ -51,9 +51,7 @@ const ViewPanel = observer(function ({
             <ReactComponent model={view} session={session} />
           </Suspense>
         </ErrorBoundary>
-      ) : (
-        false
-      )}
+      ) : null}
     </ViewContainer>
   )
 })

diff --git a/packages/core/pluggableElementTypes/models/BaseViewModel.ts b/packages/core/pluggableElementTypes/models/BaseViewModel.ts
@@ -74,7 +74,9 @@ const BaseViewModel = types
 
 export default BaseViewModel
 
-export type IBaseViewModel = Instance<typeof BaseViewModel>
+// the base view does not have type but any derived type needs to add type, so
+// just add it here
+export type IBaseViewModel = Instance<typeof BaseViewModel> & { type: string }
 
 export const BaseViewModelWithDisplayedRegions = BaseViewModel.props({
   displayedRegions: types.array(Region),