Status callback for rendering

GMOD · Jan 29, 2025 · ecada63 · ecada63
1 parent 17c3d6a
commit ecada63
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/plugins/hic/src/HicRenderer/makeImageData.ts b/plugins/hic/src/HicRenderer/makeImageData.ts
@@ -41,6 +41,10 @@ export async function makeImageData(
     regions,
     pluginManager,
   } = props
+
+  const { statusCallback = () => {} } = props
+  // @ts-expect-error
+  statusCallback('Drawing Hi-C matrix')
   const region = regions[0]!
   const { dataAdapter } = await getAdapter(
     pluginManager,

diff --git a/plugins/variants/src/MultiLinearVariantMatrixRenderer/makeImageData.ts b/plugins/variants/src/MultiLinearVariantMatrixRenderer/makeImageData.ts
@@ -51,6 +51,10 @@ export function makeImageData({
     sources,
     features,
   } = renderArgs
+
+  const { statusCallback = () => {} } = renderArgs
+  // @ts-expect-error
+  statusCallback('Drawing variant matrix')
   const h = canvasHeight / sources.length
   const mafs = getFeaturesThatPassMinorAlleleFrequencyFilter(
     features.values(),

diff --git a/plugins/variants/src/VcfTabixAdapter/VcfTabixAdapter.ts b/plugins/variants/src/VcfTabixAdapter/VcfTabixAdapter.ts
@@ -73,7 +73,7 @@ export default class VcfTabixAdapter extends BaseFeatureDataAdapter {
   public getFeatures(query: NoAssemblyRegion, opts: BaseOptions = {}) {
     return ObservableCreate<Feature>(async observer => {
       const { refName, start, end } = query
-      const { statusCallback = () => {} } = opts || {}
+      const { statusCallback = () => {} } = opts
       const { vcf, parser } = await this.configure()
 
       await updateStatus('Downloading variants', statusCallback, () =>

diff --git a/plugins/variants/src/shared/ColorLegend.tsx b/plugins/variants/src/shared/ColorLegend.tsx
@@ -40,7 +40,7 @@ const ColorLegend = observer(function ({
           <Fragment key={`${label}-${idx}`}>
             {color ? (
               <RectBg
-                y={idx * rowHeight + 1}
+                y={idx * rowHeight}
                 x={0}
                 width={colorBoxWidth + 0.5}
                 height={rowHeight + 0.5}