-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bug on URL highlight param in which refName aliases were not working #4275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4275 +/- ##
==========================================
- Coverage 62.60% 62.59% -0.01%
==========================================
Files 1087 1087
Lines 31404 31413 +9
Branches 7497 7501 +4
==========================================
+ Hits 19659 19664 +5
- Misses 11572 11574 +2
- Partials 173 175 +2 ☔ View full report in Codecov by Sentry. |
@@ -95,7 +96,16 @@ const Highlight = observer(function Highlight({ model }: { model: LGV }) { | |||
: undefined | |||
} | |||
|
|||
const h = mapCoords(model.highlight) | |||
const asm = assemblyManager.assemblies.find( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use assemblyManager.get(model.highlight.assemblyName)
instead of find here
Fixes #4261
works
https://s3.amazonaws.com/jbrowse.org/code/jb2/fix-ref-name-highlight/index.html?config=test_data%2Fconfig_demo.json&assembly=hg19&loc=1:1,937,214..2,081,004&highlight=1:2,000,000-2,100,000&tracks=repeats_hg19
works
https://s3.amazonaws.com/jbrowse.org/code/jb2/fix-ref-name-highlight/index.html?config=test_data%2Fconfig_demo.json&assembly=hg19&loc=1:1,937,214..2,081,004&highlight=chr1:2,000,000-2,100,000&tracks=repeats_hg19