chore: run clang-tidy (linter) on all files when on main or manually triggered #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with the respective functions using C++20 ranges
|
There is no change in the changelog. This PR will not produce a new releasable version. |
| - shell: bash | ||
| name: Configure and run clang-tidy on changed files | ||
| run: | | ||
| mv /src/build . |
There was a problem hiding this comment.
Why do we need this mv? Can't we cd into the correct directory?
| name: Configure and run clang-tidy on changed files | ||
| run: | | ||
| mv /src/build . | ||
| cmake -DBUILD_WITH_CLANG_TIDY=on -D CMAKE_BUILD_TYPE=Debug -B build/Debug |
There was a problem hiding this comment.
Does the space make a difference?
Suggested change
| cmake -DBUILD_WITH_CLANG_TIDY=on -D CMAKE_BUILD_TYPE=Debug -B build/Debug | |
| cmake -D BUILD_WITH_CLANG_TIDY=on -D CMAKE_BUILD_TYPE=Debug -B build/Debug |
| run: | | ||
| mv /src/build . | ||
| cmake -DBUILD_WITH_CLANG_TIDY=on -D CMAKE_BUILD_TYPE=Debug -B build/Debug | ||
| cmake --build build/Debug |
There was a problem hiding this comment.
Comparing to build_with_conan, we're usually running this with --parallel. Should we also do that here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #498
Summary
PR Checklist