458 add advanced search for covid single variant page that offers variant query #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKellerer
commented
Jan 17, 2025
There was a problem hiding this comment.
Reminder: Squash commits and rename
|
What I also left out, was a conversion of the "regular" queries to variant queries. If we want this, I think we should do this in a new ticket. |
fengelniederhammer
requested changes
Jan 22, 2025
website/src/components/pageStateSelectors/SingleVariantPageStateSelector.tsx
Outdated
Show resolved
Hide resolved
website/src/components/views/compareSideBySide/GenericCompareSideBySidePage.astro
Show resolved
Hide resolved
website/src/views/pageStateHandlers/CompareSideBySidePageStateHandler.ts
Outdated
Show resolved
Hide resolved
website/src/views/pageStateHandlers/SingleVariantPageStateHandler.spec.ts
Outdated
Show resolved
Hide resolved
added 5 commits
January 22, 2025 14:32
JonasKellerer
force-pushed
the
458-add-advanced-search-for-covid-single-variant-page-that-offers-variant-query
branch
from
18c50d0 to
5ac1603
Compare
JonasKellerer
force-pushed
the
458-add-advanced-search-for-covid-single-variant-page-that-offers-variant-query
branch
from
5ac1603 to
ca7d019
Compare
fengelniederhammer
requested changes
Jan 23, 2025
There was a problem hiding this comment.
http://localhost:4321/flu/compare-side-by-side doesn't work ("view.pageStateHandler.datasetFilterToLapisFilter is not a function")
Comment on lines
+44
to
+46
| <button className='text-sm hover:text-gray-500' onClick={() => removeVariant(id)}> | ||
| Remove | ||
| </button> |
There was a problem hiding this comment.
Maybe this is too small for mobile users. Let's see. I'm not blocking on this here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #458
Summary
Adds the option to use variantQueries for covid. Since we are in the process of supporting variantQueries for other organisms, it is implemented for all organisms and only toggled off for all except covid.
This also removes the boolean parameter "hideMutationFilter". Similar to the lineage filters, it is dependent, if there is an option for mutation filters provided. If not, it is not rendered.
Screenshot
In regular mode:
Using variant queries (on single variant page):
Using variant queries (on compare variants page):
