Rewrite some internal code to allow better disconnect handling #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code changes a few things around the codebase: - DisconnectionDetails were introduced and allow more extension in the future. Those can be used in the future to attach even more info to disconnects. (Like Minecraft does) - PacketFlow was introduced to handle server disconnect packets inside NetworkSession - NetworkSession and children now only accept MinecraftProtocol which removes unnecessary casts across the codebase and makes it easier to do Minecraft-related changes specifically. The library slowly moves away from accepting non-minecraft serlization for network sessions. - Disconnect method behaviour was changed to match Minecraft, may affect events, but tests still pass and disconnects still get handled properly with events. - Errors in packet sending are now fired on the event loop to ensure processing. - Server packet disconnect handling was moved to NetworkSession, just like Minecrafts Connection class - Add/remove checks to match Minecrafts behaviour - isConnected now no longer considers being disconnected to match Minecrafts behaviour (tests still pass) - Some small syntax cleanups where code was unnecessary.
…t to know all state switches as the NetworkSession)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code changes a few things around the codebase: