Add breadcrumbs to search results #2772
Open
+45
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e7b7cde The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zenoachtig
commented
Jan 23, 2025
| @@ -317,12 +320,15 @@ async function transformSectionsAndPage(args: { | |||
| })) ?? [], | |||
| ); | |||
|
|
|||
| const pageData = await fetchPageData({ pathname: [item.path] }); | |||
There was a problem hiding this comment.
This function correctly gets the page data when the page is in the same space as we're currently searching in, but doesn't work when we need to search across sections/variants. Any suggestions to make it work are welcome.
|
GitBook Preview |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the search displays many similarly named pages, the user has no idea which search result leads where on the site or which result they actually need.
By adding breadcrumbs, we make it easier to understand what content we're matching.