feat: SDG-6 Standardize eslint (#46)

* feat: SDG-6 Added new styleguide for React 16.8+ * Updated Deps * Added new rules to goodway/node * fix: Imports in react-hooks.js and updated npmignore to allow the new react-hooks rule to be picked up * feat: SDG-6 Added storybook plugin and rules * feat: SDG-6 Removed deps that are no longer necessary * feat: SDG-6 changed to a warning so teams are aware of the rule and can make a decision --------- Co-authored-by: Jeff Capone <[email protected]>
GoodwayGroup · Sep 1, 2023 · 42fe299 · 42fe299
1 parent 5feb22d
commit 42fe299
Show file tree

Hide file tree

Showing 7 changed files with 1,735 additions and 776 deletions.
diff --git a/.gitignore b/.gitignore
@@ -2,6 +2,7 @@
 logs
 *.log
 npm-debug.log*
+*.tgz
 
 # Runtime data
 pids

diff --git a/.npmignore b/.npmignore
@@ -1,5 +1,6 @@
 *
 !es5.js
+!react-hooks.js
 !node.js
 !index.js
 !CHANGELOG.md

diff --git a/README.md b/README.md
@@ -4,4 +4,6 @@ Node: `goodway/node`
 
 Frontend: `goodway/frontend` (doesn't exist)
 
+React: `goodway/react-hooks`
+
 ES5: `goodway/es5`
diff --git a/node.js b/node.js
@@ -8,13 +8,18 @@ module.exports = {
       'no-restricted-syntax': ['error', 'ForInStatement', 'LabeledStatement', 'WithStatement'],
       'no-return-await': ['warn'],
       'max-len': ['warn', {
-        'code': 160,
-        'ignoreUrls': true,
-        'ignoreComments': false,
-        'ignoreRegExpLiterals': true,
-        'ignoreStrings': true,
-        'ignoreTemplateLiterals': true,
-        'ignoreTrailingComments': true
+        code: 160,
+        tabWidth: 2,
+        ignoreUrls: true,
+        ignoreComments: false,
+        ignoreRegExpLiterals: true,
+        ignoreStrings: true,
+        ignoreTemplateLiterals: true,
+        ignoreTrailingComments: true,
+      }],
+      'prefer-destructuring': ['error', {
+        VariableDeclarator: {array: false, object: true},
+        AssignmentExpression: {array: false, object: false}
       }],
     }
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ @@
     logs
     *.log
     npm-debug.log*
+    *.tgz
     # Runtime data
     pids
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,4 +4,6 @@ Node: `goodway/node`

		Frontend: `goodway/frontend` (doesn't exist)

		React: `goodway/react-hooks`

		ES5: `goodway/es5`