[Feat] Passing arguments via protocol URLs #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommandMC
added
the
pr:ready-for-review
CommandMC
requested review from
arielj,
flavioislima,
Nocccer and
imLinguin
and removed request for
a team
Using URL parameters (`?foo=bar`) to specify options in protocol URLs makes them easier to extend/change later, and allows us to add features like launch parameters (which may be specified multiple times) "Old-style" URLs of course still work
The new `arg` parameter can be used (multiple times if necessary) to specify extra parameters to pass to runners/the game
CommandMC
force-pushed
the
feat/protocol-args
branch
from
c64ec6a to
059fce0
Compare
Sewer56
approved these changes
Jan 8, 2025
|
My notes on the PR are in this comment: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol URLs can now use a new format based on URL search params. This makes it possible to specify arguments to pass to runners/games when launching through them, and generally makes them easier to change/extend later.
New-style example:
Usage of protocol URLs inside Heroic has been updated accordingly
See commit messages for details
Closes #4182
Use the following Checklist if you have changed something on the Backend or Frontend: