Task/rdmp 19 more codescanning

.github/configs/codeql.yml

@@ -6,7 +6,39 @@ paths-ignore:
   - "**/obj/**"
   - "**/bin/**"
   - "**/*.Designer.cs"
+  - "*.g.cs"
 
 query-filters:
   - exclude:
-      id: cs/catch-of-all-exceptions
+      id: cs/catch-of-all-exceptions
+  - exclude:
+      id: cs/useless-assignment-to-local      
+  - exclude:
+      id: cs/local-not-disposed   
+  - exclude:
+      id: cs/missed-readonly-modifier   
+  - exclude:
+      id: cs/dereferenced-value-may-be-null  
+  - exclude:
+      id: cs/string-concatenation-in-loop 
+  - exclude:
+      id: cs/useless-cast-to-self 
+  - exclude:
+      id: cs/useless-upcast       
+  - exclude:
+      id: cs/class-missing-equals
+  - exclude:
+      id: cs/reference-equality-with-object
+  - exclude:
+      id: cs/virtual-call-in-constructor 
+  - exclude:
+      id: cs/linq/missed-where
+  - exclude:
+      id: cs/linq/missed-select
+  - exclude:
+      id: cs/nested-if-statements
+  - exclude:
+      id: cs/missed-ternary-operator 
+  - exclude:
+      id: cs/call-to-gc
+

.github/workflows/codeql.yml

@@ -32,7 +32,6 @@ jobs:
           languages: ${{ matrix.language }}
           queries: +security-and-quality
           config-file: ./.github/configs/codeql.yml
-
       - name: Build
         run: dotnet build
 

Application/ResearchDataManagementPlatform/WindowManagement/TabNavigation.cs

@@ -35,9 +35,7 @@ public void Close()
 
     public override string ToString() => Tab.TabText;
 
-    public override bool Equals(object obj) =>
-        obj is TabNavigation navigation &&
-        EqualityComparer<DockContent>.Default.Equals(Tab, navigation.Tab);
+    public override bool Equals(object obj) => obj.GetType() == typeof(TabNavigation) && EqualityComparer<DockContent>.Default.Equals(Tab, ((TabNavigation)obj).Tab);
 
     public override int GetHashCode()
     {

Rdmp.Core.Tests/Curation/Integration/CommitInProgressTests.cs

@@ -54,26 +54,24 @@ public void CommitInProgress_TestCancellation()
         Assert.That(c.HasLocalChanges().Evaluation, Is.EqualTo(ChangeDescription.NoChanges),
             "We just created this Catalogue, how can db copy be different?!");
 
-        var start = new CommitInProgress(RepositoryLocator, new CommitInProgressSettings(c)
+        using (var start = new CommitInProgress(RepositoryLocator, new CommitInProgressSettings(c)
         {
             UseTransactions = true
-        });
-
-        // there is a CommitInProgress on c so db should not have
-        c.Name = "abadaba";
-        c.IsDeprecated = true;
-
-        Assert.That(c.HasLocalChanges().Evaluation, Is.EqualTo(ChangeDescription.DatabaseCopyDifferent),
-            "We have local changes");
+        }))
+        {
+            // there is a CommitInProgress on c so db should not have
+            c.Name = "abadaba";
+            c.IsDeprecated = true;
 
-        c.SaveToDatabase();
+            Assert.That(c.HasLocalChanges().Evaluation, Is.EqualTo(ChangeDescription.DatabaseCopyDifferent),
+                "We have local changes");
 
-        Assert.That(c.HasLocalChanges().Evaluation, Is.EqualTo(ChangeDescription.NoChanges),
-            "Should be saved inside the transaction");
+            c.SaveToDatabase();
 
-        // abandon the commit
-        start.Dispose();
+            Assert.That(c.HasLocalChanges().Evaluation, Is.EqualTo(ChangeDescription.NoChanges),
+                "Should be saved inside the transaction");
 
+        }
         Assert.That(c.HasLocalChanges().Evaluation, Is.EqualTo(ChangeDescription.DatabaseCopyDifferent),
             "With transaction rolled back the Catalogue should now no longer match db state - i.e. be unsaved");
 

Rdmp.Core.Tests/Curation/Integration/LookupTest.cs

@@ -81,6 +81,7 @@ public void CreateLookup_linkWithSelfThrowsException()
             }
             catch (Exception)
             {
+                Console.WriteLine("Unable To Delete child");
             }
 
             try
@@ -89,6 +90,7 @@ public void CreateLookup_linkWithSelfThrowsException()
             }
             catch (Exception)
             {
+                Console.WriteLine("Unable To Delete child");
             }
 
             try
@@ -97,6 +99,7 @@ public void CreateLookup_linkWithSelfThrowsException()
             }
             catch (Exception)
             {
+                Console.WriteLine("Unable To Delete child");
             }
 
             try
@@ -105,6 +108,7 @@ public void CreateLookup_linkWithSelfThrowsException()
             }
             catch (Exception)
             {
+                Console.WriteLine("Unable To Delete child");
             }
         }
 
@@ -114,6 +118,7 @@ public void CreateLookup_linkWithSelfThrowsException()
         }
         catch (Exception)
         {
+            Console.WriteLine("Unable To Delete child");
         }
     }
 
@@ -162,6 +167,7 @@ public void CreateLookup_linkWithOtherTable(bool memoryRepo)
             }
             catch (Exception)
             {
+                Console.WriteLine("Unable To Delete child");
             }
 
             try
@@ -170,6 +176,7 @@ public void CreateLookup_linkWithOtherTable(bool memoryRepo)
             }
             catch (Exception)
             {
+                Console.WriteLine("Unable To Delete child");
             }
 
             try
@@ -178,6 +185,7 @@ public void CreateLookup_linkWithOtherTable(bool memoryRepo)
             }
             catch (Exception)
             {
+                Console.WriteLine("Unable To Delete child");
             }
 
             try
@@ -186,6 +194,7 @@ public void CreateLookup_linkWithOtherTable(bool memoryRepo)
             }
             catch (Exception)
             {
+                Console.WriteLine("Unable To Delete child");
             }
 
             try
@@ -194,6 +203,7 @@ public void CreateLookup_linkWithOtherTable(bool memoryRepo)
             }
             catch (Exception)
             {
+                Console.WriteLine("Unable To Delete child");
             }
         }
     }

Rdmp.Core.Tests/Curation/Unit/AggregateConfigurationTests.cs

@@ -17,47 +17,52 @@ internal class AggregateConfigurationTests : UnitTests
     [Test]
     public void TestStripZeroSeries_EmptyTable()
     {
-        var dt = new DataTable();
-        dt.Columns.Add("col1");
-        dt.Columns.Add("col2");
+        using (var dt = new DataTable())
 
-        UserSettings.IncludeZeroSeriesInGraphs = false;
+        {
+            dt.Columns.Add("col1");
+            dt.Columns.Add("col2");
+
+            UserSettings.IncludeZeroSeriesInGraphs = false;
 
-        // empty tables should not get nuked
-        AggregateConfiguration.AdjustGraphDataTable(dt);
-        Assert.That(dt.Columns, Has.Count.EqualTo(2));
+            // empty tables should not get nuked
+            AggregateConfiguration.AdjustGraphDataTable(dt);
+            Assert.That(dt.Columns, Has.Count.EqualTo(2));
+        }
 
-        dt.Dispose();
     }
 
+
     [TestCase(true)]
     [TestCase(false)]
     public void TestStripZeroSeries_Nulls(bool includeZeroSeries)
     {
-        var dt = new DataTable();
-        dt.Columns.Add("date");
-        dt.Columns.Add("col1");
-        dt.Columns.Add("col2");
+        using (var dt = new DataTable())
+        {
+            dt.Columns.Add("date");
+            dt.Columns.Add("col1");
+            dt.Columns.Add("col2");
 
-        dt.Rows.Add("2001", 0, 12);
-        dt.Rows.Add("2002", null, 333);
+            dt.Rows.Add("2001", 0, 12);
+            dt.Rows.Add("2002", null, 333);
 
-        UserSettings.IncludeZeroSeriesInGraphs = includeZeroSeries;
+            UserSettings.IncludeZeroSeriesInGraphs = includeZeroSeries;
 
-        AggregateConfiguration.AdjustGraphDataTable(dt);
+            AggregateConfiguration.AdjustGraphDataTable(dt);
 
-        if (includeZeroSeries)
-        {
-            Assert.That(dt.Columns, Has.Count.EqualTo(3));
-        }
-        else
-        {
-            // col1 should have been gotten rid of
-            Assert.That(dt.Columns, Has.Count.EqualTo(2));
-            dt.Columns.Contains("date");
-            dt.Columns.Contains("col2");
+            if (includeZeroSeries)
+            {
+                Assert.That(dt.Columns, Has.Count.EqualTo(3));
+            }
+            else
+            {
+                // col1 should have been gotten rid of
+                Assert.That(dt.Columns, Has.Count.EqualTo(2));
+                dt.Columns.Contains("date");
+                dt.Columns.Contains("col2");
+            }
         }
 
-        dt.Dispose();
     }
+
 }

Rdmp.Core.Tests/DataExport/DataExtraction/ExecuteDatasetExtractionFlatFileDestinationTests.cs

@@ -26,35 +26,36 @@ public void ExtractionDestination_FloatRounding(bool lotsOfDecimalPlaces)
     {
         var dest = new ExecuteDatasetExtractionFlatFileDestination();
 
-        var dt = new DataTable();
-        dt.Columns.Add("Floats", typeof(decimal));
+        using (var dt = new DataTable())
+        {
 
-        dt.Rows.Add(Math.PI);
+            dt.Columns.Add("Floats", typeof(decimal));
 
-        var lm = new LogManager(new DiscoveredServer(UnitTestLoggingConnectionString));
-        lm.CreateNewLoggingTaskIfNotExists("ExtractionDestination_FloatRounding");
+            dt.Rows.Add(Math.PI);
 
-        var dli = lm.CreateDataLoadInfo("ExtractionDestination_FloatRounding",
-            nameof(ExecuteDatasetExtractionFlatFileDestinationTests), "test", "", true);
+            var lm = new LogManager(new DiscoveredServer(UnitTestLoggingConnectionString));
+            lm.CreateNewLoggingTaskIfNotExists("ExtractionDestination_FloatRounding");
 
-        if (_request.QueryBuilder == null) _request.GenerateQueryBuilder();
-        dest.RoundFloatsTo = lotsOfDecimalPlaces ? 10 : 2;
+            var dli = lm.CreateDataLoadInfo("ExtractionDestination_FloatRounding",
+                nameof(ExecuteDatasetExtractionFlatFileDestinationTests), "test", "", true);
 
-        dest.PreInitialize(_request, ThrowImmediatelyDataLoadEventListener.Quiet);
-        dest.PreInitialize(_project, ThrowImmediatelyDataLoadEventListener.Quiet);
-        dest.PreInitialize((DataLoadInfo)dli, ThrowImmediatelyDataLoadEventListener.Quiet);
+            if (_request.QueryBuilder == null) _request.GenerateQueryBuilder();
+            dest.RoundFloatsTo = lotsOfDecimalPlaces ? 10 : 2;
 
-        dest.ProcessPipelineData(dt, ThrowImmediatelyDataLoadEventListener.Quiet, new GracefulCancellationToken());
-        dest.Dispose(ThrowImmediatelyDataLoadEventListener.Quiet, null);
+            dest.PreInitialize(_request, ThrowImmediatelyDataLoadEventListener.Quiet);
+            dest.PreInitialize(_project, ThrowImmediatelyDataLoadEventListener.Quiet);
+            dest.PreInitialize((DataLoadInfo)dli, ThrowImmediatelyDataLoadEventListener.Quiet);
 
-        Assert.That(dest.OutputFile, Is.Not.Null);
-        FileAssert.Exists(dest.OutputFile);
+            dest.ProcessPipelineData(dt, ThrowImmediatelyDataLoadEventListener.Quiet, new GracefulCancellationToken());
+            dest.Dispose(ThrowImmediatelyDataLoadEventListener.Quiet, null);
 
-        Assert.That(
-File.ReadAllText(dest.OutputFile), Is.EqualTo(lotsOfDecimalPlaces
-                ? $"Floats{Environment.NewLine}3.1415926536{Environment.NewLine}"
-                : $"Floats{Environment.NewLine}3.14{Environment.NewLine}"));
+            Assert.That(dest.OutputFile, Is.Not.Null);
+            FileAssert.Exists(dest.OutputFile);
 
-        dt.Dispose();
+            Assert.That(
+    File.ReadAllText(dest.OutputFile), Is.EqualTo(lotsOfDecimalPlaces
+                    ? $"Floats{Environment.NewLine}3.1415926536{Environment.NewLine}"
+                    : $"Floats{Environment.NewLine}3.14{Environment.NewLine}"));
+        }
     }
 }